Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue-4358: Add Code Linter To utopia-php/messaging #11

Merged
merged 1 commit into from
Dec 20, 2022

Conversation

Rutam21
Copy link
Contributor

@Rutam21 Rutam21 commented Oct 30, 2022

What

This PR aims to resolve the issue appwrite/appwrite#4358.

How

  • Code Linter has been added to utopia-php/messaging repository.
  • All existing files are formatted as per the Linting rules.
  • PR Template has been followed as mentioned in Feat: Implement linter ab#7.

Fixes appwrite/appwrite#4358

Have you read the Contributing Guidelines on issues?

@Rutam21
Copy link
Contributor Author

Rutam21 commented Oct 30, 2022

@Meldiron Please review and suggest changes, if any. Thanks.

cc: @stnguyen90 @christyjacob4

@PineappleIOnic
Copy link
Member

Thank you so much for the PR 🤩. We're adding the hacktoberfest-accepted label to ensure this PR counts towards your Hacktoberfest contributions count. With that said, please stay active on this PR to address any comments once you receive a review. Happy Hacktoberfest! 🎃

@stnguyen90 stnguyen90 self-requested a review November 17, 2022 20:12
Copy link
Contributor

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey 👋 awesome work on your PR! We've approved your work and it'll be merged soon!

@christyjacob4 christyjacob4 merged commit 3a0d6b9 into utopia-php:main Dec 20, 2022
@christyjacob4
Copy link
Contributor

THANK YOU! All changes merged 🥳

Please reach out to me on our Discord server if you would like to claim your Appwrite swags! As a way of saying thank you, we would also love to invite you to join the Appwrite organization on GitHub. Please share your GitHub username with us on Discord.  

You can accept the invite by visiting https://github.com/orgs/appwrite/invitation. By joining our team, you will officially be an Appwrite maintainer on GitHub.

You can change your membership visibility settings, so your new Appwrite team membership badge will show up on your personal GitHub profile.

Please feel free to look for more PRs you might be interested in helping with on our long list of Hacktoberfest friendly issues and help make Appwrite better :)

@DhairyaMajmudar
Copy link

Hi @christyjacob4 @stnguyen90 one of my PR has been approved but still not yet merged as of which I am not able to get the hacktoberfest swags please spare some time to merge it.

#54

Thank You : )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💄 Add Code Linter To ‘utopia-php/messaging’
5 participants