Merge pull request #53 from utopia-php/feat-orbit-hotfix

Add non-string tests and fixes to Orbit Adapter
utopia-php · Feb 20, 2024 · fd2c068 · fd2c068
2 parents 42b0545 + 85246e8
commit fd2c068
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/Analytics/Adapter/Orbit.php b/src/Analytics/Adapter/Orbit.php
@@ -73,6 +73,10 @@ public function send(Event $event): bool
                     return json_encode($value);
                 }
 
+                if (is_bool($value)) {
+                    return $value ? 'true' : 'false';
+                }
+
                 return strval($value);
             }, array_filter($event->getProps(), fn ($value) => ! is_null($value) && $value !== '')),
         ];

diff --git a/tests/Analytics/AnalyticsTest.php b/tests/Analytics/AnalyticsTest.php
@@ -219,7 +219,7 @@ public function testOrbit(): void
         $event->setType('testEvent')
             ->setName('testEvent')
             ->setUrl('https://www.appwrite.io/docs/installation')
-            ->setProps(['category' => 'testEvent', 'email' => 'analytics@utopiaphp.com', 'tags' => ['test', 'test2']]);
+            ->setProps(['category' => 'testEvent', 'email' => 'analytics@utopiaphp.com', 'tags' => ['test', 'test2'], 'non_string' => false]);
 
         $this->assertTrue($this->orbit->send($event));
         $this->assertTrue($this->orbit->validate($event));