Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #5937 - improved VM icon selector UX #5969

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Conversation

js-john
Copy link
Contributor

@js-john js-john commented Dec 13, 2023

Solved "Add a tooltip when selecting an OS icon for the selected VM?" #5937

macOS
Screenshot_2023-12-13 13 35 19_UTS18j

Removed extra icon picker pop over for iOS / iPadOS

iPadOS
Screenshot_2023-12-13 13 34 43_VmeLQ3

iOS
Screenshot_2023-12-13 13 35 40_SqnhUH

@osy osy added this to the Future milestone Feb 26, 2024
@osy osy modified the milestones: Future, v4.5 Apr 30, 2024
@osy osy merged commit 9f8c1a8 into utmapp:main Apr 30, 2024
25 checks passed
@rxhfcy
Copy link

rxhfcy commented Apr 30, 2024

Small UI regression:

In UTM 4.5.1 (96), clicking the VM icon itself used to open the "icon picker".
In 4.5.2 (97) however, clicking the VM icon now does nothing, only the new button works

Suggestion: why not make clicking the icon still work as earlier? Feels pretty obvious that if someone clicks the icon, showing the "picker" wouldn't be a surprise. Doing nothing would just be a bit pedantic I think :)

@osy
Copy link
Contributor

osy commented Apr 30, 2024

Feel free to open a new issue with your suggestion as this PR has already been closed.

@rxhfcy
Copy link

rxhfcy commented Apr 30, 2024

Feel free to open a new issue with your suggestion as this PR has already been closed.

OK thanks, I opened new issue #6316

@rxhfcy
Copy link

rxhfcy commented Apr 30, 2024

Also see #6317 for UI wonkiness if the OS name doesn't fit on one line in the icon picker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants