Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify sidecar resource requests and limits #182

Merged
merged 2 commits into from
Mar 14, 2023

Conversation

Nesze
Copy link
Member

@Nesze Nesze commented Mar 13, 2023

I suspect the lack of this messes with our HPAs. From the docs:

Please note that if some of the Pod's containers do not have the relevant resource request set, CPU utilization for the Pod will not be defined and the autoscaler will not take any action for that metric

IAM HPAs (i.e. auth/hpa/iam-identity-api, auth/hpa/iam-policy-decision-api) targeting multi-container pods are failing with: failed to get memory utilization: missing request for memory. HPAs of single-container pods are OK.

$ kubectl --context prod-aws --namespace auth get events | rg horizontal

Note:

  • Values were roughly taken from the operator
  • Probably lot less would suffice, but didn't find an appropriate dashboard in grafana, and haven't investigated it further. Happy to adjust it.
  • Screenshot 2023-03-13 at 17 29 57

@Nesze Nesze requested a review from george-angel March 13, 2023 15:39
Also update aws-gcp-base.
@george-angel george-angel merged commit 7346dff into master Mar 14, 2023
@george-angel george-angel deleted the sidecar-resource-limits branch March 14, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants