metrics: promtool check metrics #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ribbybibby
commented
Apr 29, 2021
ribbybibby
commented
``` semaphore_policy_calico_client_request counter metrics should have "_total" suffix semaphore_policy_pod_watcher_failures counter metrics should have "_total" suffix semaphore_policy_sync_queue_full_failures counter metrics should have "_total" suffix semaphore_policy_sync_requeue counter metrics should have "_total" suffix ```
hectorhuertas
approved these changes
Apr 29, 2021
ffilippopoulos
approved these changes
Apr 29, 2021
I think all the information in the comment is pretty evident from the variables.
ffilippopoulos
approved these changes
Apr 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.