metrics: initialize counters with 0 value #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The increase() function won't recognise a move from no value -> 1 as an increase, which means it's possible for alerts to miss events. To address this, initialize every possible set of labels for each counter with a 0 value. The `semaphore_policy_sync_queue_full_failures` and `semaphore_policy_sync_requeue` CounterVecs were using the names of networksets as labels, which has an almost unbounded possible list of potential values which we obviously can't initialize ahead of time. I've decided to remove the label because: 1. It has the potential for high cardinality 2. I don't think it's necessarily important information for either metric. I'm not sure if we'd expect issues with requeueing to be networkset specific or if we'd want to split alerts by networkset. 3. If we do have an issue with a specific networkset, that information will be in the logs.
ffilippopoulos
approved these changes
Apr 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The increase() function won't recognise a move from no value -> 1 as an increase, which means it's possible for alerts to miss events.
To address this, initialize every possible set of labels for each counter with a 0 value.
The
semaphore_policy_sync_queue_full_failuresandsemaphore_policy_sync_requeueCounterVecs were using the names of networksets as labels, which has an almost unbounded possible list of potential values which we obviously can't initialize ahead of time.I've decided to remove the label because: