Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow private base without key ref or with extra comment #4

Merged
merged 3 commits into from
Oct 24, 2022

Conversation

asiyani
Copy link
Contributor

@asiyani asiyani commented Oct 24, 2022

following config is now allowed, if only 1 key is used for all private repo then there is no need to reference that key

  - github.com/org/open1//manifests/lab-foo?ref=master
  - ssh://github.com/org/repo3//manifests/lab-zoo?ref=dev

plugin will pick correct key sshKeyB from following config

  # some-extra comment : key_b argocd-voodoobox-plugin: sshKeyB
  - ssh://sshKeyB_gitlab_io/org/repo2//manifests/lab-bar?ref=main

@asiyani asiyani merged commit cb4f460 into master Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants