New backend API #9
Conversation
…recated requirement properties
There was a problem hiding this comment.
This is looking solid, great work @jdtech3. I left a few comments about how we can align with the dependecy injection pattern more closely. The advantage of doing so being that it ensures your objects or functions which want to use a given service do not have to know how to construct those services.
| router.get('/', async function(req, res, next) { | ||
| let data = await notionService.getRequirementsData(); | ||
| let data = await notionService.getRequirements('vis'); | ||
| let nodes_json = JSON.stringify(data.nodes); | ||
| let edges_json = JSON.stringify(data.edges); | ||
| res.render('index', { title: 'TreeVisualizer' , nodes: nodes_json, edges: edges_json}); | ||
| }); | ||
|
|
||
| // GET : JSON API | ||
| router.get('/api/requirements', async function(req, res, next) { | ||
| let data = await notionService.getRequirementsData(); | ||
| let data = await notionService.getRequirements('api'); | ||
| res.json(data); | ||
| }); |
There was a problem hiding this comment.
What's the use case for each of these two routes? Do we need both?
There was a problem hiding this comment.
We do not, no. Honestly it's probably not great practice, but the legacy demo functionality is serving as an easy sanity test to see whether data is being fetched from the Notion API correctly—JSON is hard to read, but if vis graph generates, data is probably fine.
Having said that, no real need, should I remove?
There was a problem hiding this comment.
Gotcha, your call to make, if its a quality of life feature we can keep both
Co-authored-by: David Maranto <34867698+DM1122@users.noreply.github.com>
Resolves #6 with new backend API of form:
{ "ff5892a7-b5c9-4a25-97bd-663b2cff5bd7": { "created-by": "khang nguyen", "parent-id": "b7985ca8-94f4-4a30-ae61-8af2126019bd", "last-edited": "2023-02-20T17:51:00.000Z", "qualifier": "SHALL", "collection": [ "Volume Allocation & Placement" ], "verification-plan": [ "TVAC Testing Plan" ], "system": "Tree Visualizer", "rationale": "To allow UTAT Space Systems members to graphically view the relationships between entries", "trades": [ "Spacecraft Bus Stack Order Selection" ], "last-edited-by": "David", "stakeholder": [ "Mechanical", "Power", "Thermal" ], "mission": "FINCH", "description": "ADCS shall consistently know FINCH’s location relative to the SUN and Earth Position", "title": "FINCH-ADCS-AttitudeDetermination", "url": "https://www.notion.so/FINCH-Power-Batteries-74331bc1129c417c850a0a5ca0deb759" }, [...] }Note: this is slightly different from description in #6 due to Requirements DB changes.