Fix warnings in Vector-Matrix library #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sksat
reviewed
Apr 19, 2022
src/Library/math/MatVec_impl.hpp
Outdated
Comment on lines
3
to
5
| \author TAKISAWA Jun'ichi. | ||
| \date Wed Oct 27 21:18:38 2010 | ||
|
|
There was a problem hiding this comment.
author消すのはちょっとよくないのでは？(それとも最終更新者という意味でしかない？)
There was a problem hiding this comment.
更新をかけていった場合に、誰がauthorになるのか、どの程度の更新ならauthorとするのかという問題を昔議論した時に、まあ全てはcommitログに残るから消してよいのでは？ということになりました。
ただ、実はこのファイルはとても古くcommitログにこの著者情報も残っていないので、消さないほうが良い説もあるのかもしれません。
There was a problem hiding this comment.
なるほどー．まあ難しいですよね．とはいえ安全側に倒すなら残す or 「元々の著者はこの人」，みたいな表示にしておくか，ですかねー．
There was a problem hiding this comment.
たしかにそうですよね。情報残すように修正しておきます！
sksat
approved these changes
Apr 19, 2022
|
approve頂いていますし、追加修正もコメントだけなのでマージします。 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix warnings in Vector-Matrix library
Issue
Details
Warnings in g++ environment is reduced from 602 to 182 in the
PROBLEMSwindow in the VS code.Validation results
NA
Scope of influence
Small. The algorithm is not changed.
Supplement
NA
Note
NA