Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cache ExtLibraries in build CI #41

Merged
merged 2 commits into from
Jan 26, 2022
Merged

Add cache ExtLibraries in build CI #41

merged 2 commits into from
Jan 26, 2022

Conversation

sksat
Copy link
Collaborator

@sksat sksat commented Jan 25, 2022

Overview

Speed-up build CI by cache ExtLibraries.

Issue

N/A

Details

  • change ExtLibraries install directory into ${GITHUB_WORKSPACE}/ExtLibraries (external deps install dir)
  • change checkout directory into ${GITHUB_WORKSPACE}/s2e-core
  • cache ${GITHUB_WORKSPACE}/ExtLibraries

Validation results

Scope of influence

eg. The behavior of XX will be change.

Supplement

Write additional comments if you need.

Note

  • If there are related Projects, tie them together.
  • Assignees should be set if possible.
  • Reviewers should be set if possible.
  • Set priority label if possible.

@sksat sksat self-assigned this Jan 25, 2022
@sksat sksat added the enhancement New feature or request label Jan 25, 2022
@sksat sksat requested review from 200km and meltingrabbit January 25, 2022 11:13
Copy link
Contributor

@meltingrabbit meltingrabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

良さそう.

そういえば,これってキャッシュが使えるか否か(新しくまたcurlしなくていいかどうか)ってどこで判断してるの?

Copy link
Contributor

@meltingrabbit meltingrabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

上記納得したので,LGTMです.

@sksat
Copy link
Collaborator Author

sksat commented Jan 26, 2022

ありがとうございます.マージします.

@sksat sksat merged commit 27f44f5 into develop Jan 26, 2022
@sksat sksat deleted the feature/cache-extlib branch January 26, 2022 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants