Fix warnings in vs2022 #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yngyu
approved these changes
Apr 25, 2022
seki-hiro
approved these changes
Apr 26, 2022
sksat
requested changes
Apr 26, 2022
sksat
reviewed
Apr 26, 2022
sksat
approved these changes
Apr 26, 2022
|
I confirmed that the all warnings in g++ and VS2022 were deleted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix warnings in vs2022
Issue
Details
vs2022で出ているwarningsを全て削除した。
ただし、algorithmのtransformを使っている
IniReader.cppで出ているwarningをどう解決すべきかわからず、そこは手をつけれていない。-> The warning in transform was removed!
Validation results
前後でログ出力結果が変わらないことは確認した
Scope of influence
ユーザーに影響する修正はない
Supplement
NA
Note
GNSS関係の部分で結構修正を入れているので、牛くんにもレビューしてもらう