Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix function prototype mismatch in Applications #622

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Fix function prototype mismatch in Applications #622

merged 1 commit into from
Jun 28, 2023

Conversation

sksat
Copy link
Collaborator

@sksat sksat commented Jun 26, 2023 •
edited
Loading

概要

プロトタイプ宣言と定義の表記揺れ（というか void の有無）を修正

詳細

see diff

検証結果

影響範囲

warning が減る

補足

マージ後 3.9.2 をリリースしたい

@sksat sksat added the priority::medium priority medium label Jun 26, 2023
@sksat sksat self-assigned this Jun 26, 2023
@sksat sksat requested a review from meltingrabbit June 26, 2023 09:25
meltingrabbit
meltingrabbit approved these changes Jun 28, 2023
View reviewed changes
Copy link
Collaborator

@meltingrabbit meltingrabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

よさそう．

pytest は バージョンあげPRでまわします

@sksat sksat merged commit 59a8c53 into develop Jun 28, 2023
@sksat sksat deleted the feature/fix-prototype-mismatch branch June 28, 2023 05:05
@meltingrabbit meltingrabbit mentioned this pull request Jun 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meltingrabbit meltingrabbit meltingrabbit approved these changes

Assignees

@sksat sksat

Labels
priority::medium priority medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sksat @meltingrabbit