WallオプションででるWarningを消す #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meltingrabbit
added
enhancement
|
-Werror オプションをつけると， https://github.com/ut-issl/c2a-core/runs/4341988868?check_suite_focus=true のように確かに落ちたが，Warningが出た時点でコンパイルが止まった． できれば最後までコンパイルし，Warning一覧を見たいところ． |
|
コンパイル結果をファイルに出力し，grepするのがいいのかしら？ |
meltingrabbit
force-pushed
the
feature/delete_warning
branch
from
82aae1e to
8f1e1ee
Compare
meltingrabbit
force-pushed
the
feature/delete_warning
branch
from
8905379 to
c5c4920
Compare
|
CIは落とさない WextraのビルドCIをいれた |
|
Wextraはともかく（多少減らしたけど），Wallは一旦全て消えたのでは？ |
sksat
requested changes
Nov 28, 2021
sksat
reviewed
Nov 28, 2021
| else() | ||
| target_compile_options(${PROJECT_NAME} PUBLIC "${CMAKE_CXX_FLAGS}-Wall") | ||
| set(CMAKE_CXX_FLAGS "-finput-charset=cp932 -m32 -rdynamic -Wall -g -Wno-unknown-pragma") # SJIS, 32bit | ||
| set(CMAKE_C_FLAGS "-finput-charset=cp932 -m32 -rdynamic -Wall -g -Wno-unknown-pragmas") # SJIS, 32bit | ||
| if(ADD_WERROR_FLAGS) | ||
| set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Werror") |
There was a problem hiding this comment.
これはtarget_compile_options()でやるべきですが，どうせ後で直すので一旦スルー
sksat
approved these changes
Nov 28, 2021
|
Cmakeまわりは #35 でお願いするとして，マージします． |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
WallオプションででるWarningを消す
Issue
詳細
Warningを消すことにともなう重要な変更
検証結果
影響範囲
今後，WarningがあるPRは通らなくなる
補足
NA