Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DS buffer のバグ修正（可変フレーム，フレーム長なし，フッタあり） #501

Merged
merged 1 commit into from
Mar 1, 2023
Merged

DS buffer のバグ修正（可変フレーム，フレーム長なし，フッタあり） #501

merged 1 commit into from
Mar 1, 2023

Conversation

meltingrabbit
Copy link
Collaborator

@meltingrabbit meltingrabbit commented Feb 28, 2023 •
edited
Loading

概要

DS buffer のバグ修正（可変フレーム，フレーム長なし，フッタあり）

Issue

NA

詳細

以下の場合に発生するバグを修正

  • 可変フレーム，フレーム長なし，フッタあり
    • DS_analyze_rx_buffer_variable_pickup_with_footer_ で解析する場合
  • フレーム受信時に，そのヘッダより前にゴミデータとしてフッタの終端文字が含まれる場合

このとき，ゴミデータの終端文字をフッタと誤認してしまう．

検証結果

CIとテストがすべて通る

@meltingrabbit meltingrabbit added bug Something isn't working priority::high priorityg high labels Feb 28, 2023
@meltingrabbit meltingrabbit self-assigned this Feb 28, 2023
@meltingrabbit meltingrabbit mentioned this pull request Feb 28, 2023
Merged
hoshika-mas
hoshika-mas approved these changes Mar 1, 2023
View reviewed changes
Copy link
Contributor

@hoshika-mas hoshika-mas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

問題なさそうです。

@meltingrabbit meltingrabbit merged commit 0a2e121 into develop Mar 1, 2023
@meltingrabbit meltingrabbit deleted the feature/fix_buf_of_ds_buffer branch March 1, 2023 06:19
@meltingrabbit meltingrabbit mentioned this pull request Mar 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoshika-mas hoshika-mas hoshika-mas approved these changes

@chutaro chutaro Awaiting requested review from chutaro

Assignees

@meltingrabbit meltingrabbit

Labels
bug Something isn't working priority::high priorityg high
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meltingrabbit @hoshika-mas