Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fixed version python tools #494

Merged
merged 2 commits into from
Feb 17, 2023
Merged

Conversation

sksat
Copy link
Collaborator

@sksat sksat commented Feb 17, 2023

概要

CI で使っている Python のツールのバージョンを固定する

Issue

詳細

本当は雑に pip install するのではなくPipfileなどに書いて全環境でちゃんと固定 & Renovate で更新したいが,一旦バージョン固定されていないことにより default branch の CI が壊れるのはおかしいのでその修正

@sksat sksat added priority::high priorityg high tools labels Feb 17, 2023
@sksat sksat self-assigned this Feb 17, 2023
@sksat
Copy link
Collaborator Author

sksat commented Feb 17, 2023

@meltingrabbit 一旦これで. #492 はこれに rebase してついでにバージョン番号を23.1.0に更新するかんじでいいですか

@meltingrabbit
Copy link
Collaborator

OKそうだけど,renovateくんはここでは未対応?

@meltingrabbit
Copy link
Collaborator

flake8 も同様なのか

Copy link
Collaborator

@meltingrabbit meltingrabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OKそう.

#491

の 4 リポジトリに刺したい

@sksat
Copy link
Collaborator Author

sksat commented Feb 17, 2023

バージョン固定とバージョン更新の自動化は意図が違うので分けたい & 諸々まとめていいかんじにするので後回しという気持ち > Renovate

@sksat sksat merged commit 5755cb8 into develop Feb 17, 2023
@sksat sksat deleted the use-fixed-version-python-tools branch February 17, 2023 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants