UART TLM ON OFF を追加 #450
Merged
UART TLM ON OFF を追加 #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -80,6 +80,7 @@ typedef struct | |||
| const GS_Info* latest_info; | |||
| CCSDS_Info ccsds_info; | |||
| GS_PORT_TYPE tlm_tx_port_type; | |||
There was a problem hiding this comment.
[Q] この PR と関係ないんだけど， tlm_tx_port_type って今使われてない．．．？
There was a problem hiding this comment.
（ISSLでも使われてなさそうなら，issue化します）
There was a problem hiding this comment.
一応 gs_driver の値を表示する時に CCSDS 側の情報なのか、UART 側の情報を表示するかで使われてますね
There was a problem hiding this comment.
あ，ごめん返信みそびれてた．．．（更新されてなかった．．．）
meltingrabbit
approved these changes
Oct 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
UART TLM ON OFF を追加
Issue
N/A
詳細
検証結果
手元で Pytest が通った
影響範囲
補足
特に無し
注意