DS のフレーム長取得にパケット内部のエンディアンを考慮 #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meltingrabbit
added
enhancement
meltingrabbit
changed the base branch from
develop
to
feature/fix_endian_conv
chutaro
approved these changes
Sep 29, 2022
meltingrabbit
force-pushed
the
feature/fix_endian_conv
branch
from
05e70f6 to
1b108fe
Compare
meltingrabbit
force-pushed
the
feature/ds_endian
branch
from
845c67a to
ee8c8b2
Compare
meltingrabbit
force-pushed
the
feature/fix_endian_conv
branch
from
1b108fe to
a5f72f5
Compare
meltingrabbit
force-pushed
the
feature/ds_endian
branch
from
ee8c8b2 to
bc314d8
Compare
meltingrabbit
force-pushed
the
feature/ds_endian
branch
from
bc314d8 to
db9da0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
DS のフレーム長取得にパケット内部のエンディアンを考慮
Issue
詳細
see diff
検証結果
既存のテストが全て通った
本質的な検証はテストではできないのでしっかりレビューして欲しい
影響範囲
後方互換性あり