Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unneeded CMake target_properties() #368

Merged
merged 1 commit into from
Jun 28, 2022
Merged

Remove unneeded CMake target_properties() #368

merged 1 commit into from
Jun 28, 2022

Conversation

sksat
Copy link
Collaborator

@sksat sksat commented Jun 28, 2022 •
edited by meltingrabbit
Loading

概要

不要なCMake target propertyを消す

Issue

NA

詳細

検証結果

CIが通ればよし

影響範囲

CMakeの修正なのでSILS環境下のみ．無意味な設定を削るだけなので動作は変わらないはず．

@sksat sksat added invalid This doesn't seem right tools S2E labels Jun 28, 2022
@sksat sksat self-assigned this Jun 28, 2022
@sksat
Copy link
Collaborator Author

sksat commented Jun 28, 2022

build_s2e_mockupだけ一生runner来ないな．障害？

@sksat
Copy link
Collaborator Author

sksat commented Jun 28, 2022 •
edited
Loading

runner来るのに7分，actions/checkout@v3に13分かかっていたが，まあ通ったのでよし

@sksat sksat requested a review from meltingrabbit June 28, 2022 15:05
meltingrabbit
meltingrabbit approved these changes Jun 28, 2022
View reviewed changes
Copy link
Collaborator

@meltingrabbit meltingrabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sksat sksat merged commit 09f157c into develop Jun 28, 2022
@sksat sksat deleted the hotfix/remove-unneeded-cmake-target-property branch June 28, 2022 15:12
@meltingrabbit meltingrabbit mentioned this pull request Jun 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meltingrabbit meltingrabbit meltingrabbit approved these changes

Assignees

@sksat sksat

Labels
invalid This doesn't seem right S2E tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sksat @meltingrabbit