Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CMake option default value config #329

Merged
merged 1 commit into from
May 19, 2022
Merged

Fix CMake option default value config #329

merged 1 commit into from
May 19, 2022

Conversation

sksat
Copy link
Collaborator

@sksat sksat commented May 18, 2022 •
edited by meltingrabbit
Loading

概要

CMakeでoption()のデフォルト値として指定したいという意図のものがset()で設定されているので修正

Issue

@sksat sksat added the bug Something isn't working label May 18, 2022
@sksat sksat self-assigned this May 18, 2022
@sksat sksat requested a review from meltingrabbit May 19, 2022 09:28
@meltingrabbit
Copy link
Collaborator

あ～，なるほどね．当初想定だと，このminimum userは当然WINGS ONで使うでしょ，って想定だったので， optionの使い方もこめてsetにしてたけど，今は別にそれ以外でも使いたくなってきたからという感じか．

meltingrabbit
meltingrabbit approved these changes May 19, 2022
View reviewed changes
Copy link
Collaborator

@meltingrabbit meltingrabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです～

@sksat
Copy link
Collaborator Author

sksat commented May 19, 2022

です > 他でも使いたくなってきたから

@sksat
Copy link
Collaborator Author

sksat commented May 19, 2022

ということでマージ

@sksat sksat merged commit 2cd9857 into develop May 19, 2022
@sksat sksat deleted the hotfix/wrong-cmake-default-option branch May 19, 2022 10:14
@meltingrabbit meltingrabbit mentioned this pull request Jun 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meltingrabbit meltingrabbit meltingrabbit approved these changes

Assignees

@sksat sksat

Labels
bug Something isn't working priority::high priorityg high S2E tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sksat @meltingrabbit