Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CCP register cmd 関数の追加 #320

Merged
merged 5 commits into from
Apr 26, 2022
Merged

CCP register cmd 関数の追加 #320

merged 5 commits into from
Apr 26, 2022

Conversation

yngyu
Copy link
Contributor

@yngyu yngyu commented Apr 22, 2022 •
edited
Loading

概要

CCP register cmd 関数の追加

Issue

詳細

form と PH_analyze_packet をまとめた register を作成した

検証結果

N/A

影響範囲

小

@yngyu yngyu added enhancement New feature or request priority::medium priority medium labels Apr 22, 2022
@yngyu yngyu requested review from chutaro and meltingrabbit April 22, 2022 05:30
@yngyu yngyu self-assigned this Apr 22, 2022
@yngyu yngyu changed the title CCP send cmd 関数の追加 Draft: CCP send cmd 関数の追加 Apr 22, 2022
@meltingrabbit
Copy link
Collaborator

diffちゃんと見ずにコメントしてます．

PH_analyze_cmd_packet だとキューに入るよね．あと即時実行したいとき，つまり PH_dispatch_command に送る場合のもこのPRでも他のPRでもいいので多分作っていくことになると思っていて，それを見据えた命名にしてほしいかも？

@yngyu yngyu force-pushed the feature/ccp_send_cmd branch from 0e92f3c to 69072ac Compare April 22, 2022 07:59
@yngyu yngyu changed the title Draft: CCP send cmd 関数の追加 CCP send cmd 関数の追加 Apr 22, 2022
@yngyu
Copy link
Contributor Author

yngyu commented Apr 22, 2022

send -> register に変えました

@yngyu yngyu changed the title CCP send cmd 関数の追加 CCP register cmd 関数の追加 Apr 25, 2022
@yngyu yngyu force-pushed the feature/ccp_send_cmd branch from cb49095 to 96498bc Compare April 25, 2022 02:42
@meltingrabbit
Copy link
Collaborator

バージョン上がってるのでrebaseお願いします！

@yngyu yngyu force-pushed the feature/ccp_send_cmd branch from 96498bc to 8c1c389 Compare April 26, 2022 04:20
@yngyu yngyu merged commit bb99a60 into develop Apr 26, 2022
@yngyu yngyu deleted the feature/ccp_send_cmd branch April 26, 2022 08:06
@yngyu yngyu mentioned this pull request Apr 26, 2022
Closed
@meltingrabbit meltingrabbit mentioned this pull request Jun 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meltingrabbit meltingrabbit meltingrabbit approved these changes

@chutaro chutaro Awaiting requested review from chutaro

Assignees

@yngyu yngyu

Labels
enhancement New feature or request priority::medium priority medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yngyu @meltingrabbit