PH の返り値を元に戻す #281
Merged
PH の返り値を元に戻す #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[NITS] テレメCSVのstatus変換も？（これ，整合性担保だるいんで，なんとかしたいねぇ．．．） |
|
issueはたてた ut-issl/tlm-cmd-db#9 |
| @@ -35,9 +35,9 @@ PH_ACK PH_user_analyze_cmd(const CommonCmdPacket* packet) | |||
| switch (CCP_get_dest_type(packet)) | |||
| { | |||
| case CCP_DEST_TYPE_TO_AOBC: | |||
| return (PH_add_aobc_cmd_(packet) == PH_ACK_SUCCESS) ? PH_ACK_SUCCESS : PH_ACK_PL_LIST_FULL; | |||
| return (PH_add_aobc_cmd_(packet) == PH_ACK_SUCCESS) ? PH_ACK_FORWARDED : PH_ACK_PL_LIST_FULL; | |||
There was a problem hiding this comment.
[NITS] PH_user_analyze_cmd の doxygen commentのretvalも修正お願いします
yngyu
force-pushed
the
feature/fix_ph_ret
branch
from
603ad73 to
cafc6d2
Compare
|
諸々修正して rebase しました |
meltingrabbit
approved these changes
Mar 7, 2022
yngyu
force-pushed
the
feature/fix_ph_ret
branch
from
cafc6d2 to
b25473b
Compare
|
rebase して CI 通ったのでマージする |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
PH の返り値を元に戻す
Issue
N/A
詳細
#242 で返り値が複数あってわかりにくかったので、
PH_ACK_SUCCESSのみで統一していたが、実用上どこに登録されたのかデバッグなどで見にくい、という話が上がったので戻すことにした検証結果
手元で test を通した
影響範囲
小