Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSCD,TLCD,RTCDなどの実行時エラー履歴を残す #268

Merged
merged 6 commits into from
Apr 1, 2022

Conversation

chutaro
Copy link
Contributor

@chutaro chutaro commented Mar 1, 2022

概要

GSCD,TLCD,RTCDなどの実行時エラー履歴をELに記録して残す

Issue

詳細

検証結果

実行時エラーがEL_TLOGテレメに登録されるのを SILSとwingsで確認した

影響範囲

@chutaro chutaro added enhancement New feature or request priority::medium priority medium labels Mar 1, 2022
@chutaro chutaro requested a review from meltingrabbit March 1, 2022 10:09
@chutaro chutaro self-assigned this Mar 1, 2022
TlmCmd/command_dispatcher.c Outdated Show resolved Hide resolved
@chutaro chutaro force-pushed the feature/record_CDIS_err_to_EL branch 2 times, most recently from 9050c93 to 548f995 Compare March 5, 2022 04:19
@chutaro chutaro force-pushed the feature/record_CDIS_err_to_EL branch from 548f995 to 6fb1797 Compare March 14, 2022 05:18
@chutaro
Copy link
Contributor Author

chutaro commented Mar 14, 2022

遅くなりましたが,EL pytestの修正まで終わったのでレビューお願いします。

local: cdisのアドレス
note: 上位16bitをエラーのでたcmd code,下位16bitをexec sts

これですが,HK, EL_TLOG, EL_CLOGのテレメだとnoteがuint8_tuint16_tになっているので,wingsだとcmd_codeが見えないです。ELテレメだとnoteがuint32_t表示なので見れます。

@meltingrabbit
Copy link
Collaborator

これですが,HK, EL_TLOG, EL_CLOGのテレメだとnoteがuint8_tかuint16_tになっているので,wingsだとcmd_codeが見えないです。ELテレメだとnoteがuint32_t表示なので見れます。

ELテレメで見えればいいと思う.

noteって普段はいらない(補足情報なので)ので圧縮してます.

HKぐらいは32bitにしてもいいかもしれない気もしてきました.

@meltingrabbit
Copy link
Collaborator

meltingrabbit commented Mar 17, 2022

うー,EL_TLOG,CLOGのtlmのnoteも32bitにしたほうがいい気がしてきたなあ.

それ,先にやったほうがいいならこっちでさっとやりますがどうしましょう?

@chutaro

This comment was marked as outdated.

@chutaro chutaro force-pushed the feature/record_CDIS_err_to_EL branch from e079af1 to 954fad4 Compare March 29, 2022 03:12
@chutaro
Copy link
Contributor Author

chutaro commented Mar 29, 2022

ものすごく時間あいてしまったのですが,レビュー対応してrebaseしてpytestも全て通っているので,最後に確認お願いします。

Copy link
Collaborator

@meltingrabbit meltingrabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

良さそう!

@chutaro chutaro merged commit 71bef77 into develop Apr 1, 2022
@chutaro chutaro deleted the feature/record_CDIS_err_to_EL branch April 1, 2022 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority::medium priority medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants