DRのないOBCで，不要なメモリを確保しないようにする #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[IMO] ほとんどが ifndef + DISABlE で 2重否定になっているので、デフォルトとは言え |
|
どっちがいいか悩んでました． 結局，
だと思っていて，どっちが標準なん？となり，ま～あるのが標準やろ～～～となって今にしてました． どっちがいいかね？ |
うん，紛らわしい． |
|
ぐちょくに ってのと，もはやこれ 今後，DRをcoreに入れた時，全体をこのifdefでくるむことになると思うんだよね． となると，このdefはどこに置くのが良いんだ？ |
|
|
で良いと思います #define USE_DATA_RECORDER
#ifdef USE_DATA_RECORDER
#define DRのパラメーター
~
#endifとか? |
|
なんか，これのためだけに
|
|
接頭辞考えて， |
meltingrabbit
force-pushed
the
feature/select_dr_enable
branch
from
a8eb378 to
5aa0319
Compare
|
直しました． |
meltingrabbit
force-pushed
the
feature/select_dr_enable
branch
2 times, most recently
from
d6be989 to
f6a603c
Compare
yngyu
reviewed
Mar 5, 2022
TlmCmd/packet_handler.c
Outdated
Comment on lines
293
to
305
| static PH_ACK PH_add_st_tlm_(const CommonTlmPacket* packet) | ||
| { | ||
| #ifdef DR_ENABLE | ||
| PL_ACK ack = PL_push_back(&PH_st_tlm_list, packet); | ||
|
|
||
| if (ack != PL_SUCCESS) return PH_ACK_PL_LIST_FULL; | ||
|
|
||
| return PH_ACK_SUCCESS; | ||
| #else | ||
| (void)packet; | ||
| return PH_ACK_SUCCESS; | ||
| #endif | ||
| } |
There was a problem hiding this comment.
[IMO] この関数まるごと #ifdef #endif で良いと思います
There was a problem hiding this comment.
meltingrabbit
force-pushed
the
feature/select_dr_enable
branch
from
f6a603c to
7f379e7
Compare
yngyu
approved these changes
Mar 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
DRのないOBCで，不要なメモリを確保しないようにする
Issue
NA
詳細
stored tlmとreploay tlmのpacket listを，DRのないボードではメモリ確保しないようにした
検証結果
c2a-core/Examples/minimum_user_for_s2e/src/src_user/Settings/TlmCmd/packet_handler_params.h
Line 35 in a8eb378