example用userのディレクトリ名の修正 #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meltingrabbit
approved these changes
Nov 22, 2021
|
ですよね．びっくりした． |
|
パス名は長いなぁと思ってたけど，まあそのまま愚直に書くか～，という感じだった． これでもわかるしスッキリするのでこれで良さそう． |
|
sampleであることは自明ですし，buildは冗長なんですよね．あとそういう情報はREADMEにちゃんと書いてあれば問題無い． |
Examplesの下にあるので，自明だね． LGTMなので，マージどうぞ～ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
Examples/maximum_user_sample_for_s2e_buildは長すぎるしminimumのtypoっぽいIssue