Remove duplicate error on reviewdog #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sksat
force-pushed
the
feature/skip-same-error
branch
from
795d891 to
2a22f03
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
sksat
force-pushed
the
feature/skip-same-error
branch
2 times, most recently
from
1d12637 to
20ca2f5
Compare
sksat
force-pushed
the
feature/skip-same-error
branch
from
20ca2f5 to
b2f2a2e
Compare
Examples/minimum_user_for_s2e/src/src_user/TlmCmd/command_definitions.h
Outdated
Show resolved
Hide resolved
Examples/minimum_user_for_s2e/src/src_user/TlmCmd/command_definitions.h
Outdated
Show resolved
Hide resolved
|
なんで2個出るのかと思ったらディレクトリトラバーサル的なことがincludeで起こってるからか．それは一旦しゃあないということにしようかな |
|
テストコミット消しときます |
sksat
force-pushed
the
feature/skip-same-error
branch
from
b2f2a2e to
9af7341
Compare
| log = s.split(compiler) | ||
| if "" in log: | ||
| log.remove("") | ||
| # print(log) |
There was a problem hiding this comment.
これ何してるの？
（log って配列だよね．splitしてるし）
There was a problem hiding this comment.
これはログが初手からclang-tidyで開始してた時に最初に無が入るのでそれを消してます
There was a problem hiding this comment.
あ，なるほどね．確かにそれあると， (cmd, err) = l.split("\n", 1) で死ぬのか．
|
マージします |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
同一のファイルに対して同一のエラーが(異なるファイルから)出ている時にreviewdogの出力が重複するのを避ける
Issue
NA
詳細