Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bce command prefix #221

Merged
merged 5 commits into from
Jan 28, 2022
Merged

Fix bce command prefix #221

merged 5 commits into from
Jan 28, 2022

Conversation

yngyu
Copy link
Contributor

@yngyu yngyu commented Jan 26, 2022

概要

BCE コマンドの接頭辞を修正した

Issue

詳細

BCE コマンドの接頭辞を修正した. 合わせて Cmd_BCT_NOP は BCE ではないと思ったのでBCT側に移動させた

検証結果

手元でpytestを一通り動かして通した

影響範囲

大 (BCに関連するので)

@yngyu yngyu added good first issue Good for newcomers priority::medium priority medium labels Jan 26, 2022
@yngyu yngyu self-assigned this Jan 26, 2022
@meltingrabbit
Copy link
Collaborator

余力があれば

https://github.com/ut-issl/c2a-core/blob/develop/Docs/Tips/parameter_settings.md#block_command_table_params

を直してもらいたい気持ちもあるけど,まあ,このドキュメントは今のままだと管理がだるすぎ,一新したい気持ちもあり,なので,わざわざ今更新しなくてもいい説はある.

@yngyu yngyu force-pushed the feature/fix_bce_command_prefix branch from f69f98b to 85f6ca7 Compare January 27, 2022 14:38
@yngyu
Copy link
Contributor Author

yngyu commented Jan 27, 2022

ドキュメントも更新しました

Copy link
Collaborator

@meltingrabbit meltingrabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

よさそう

@yngyu
Copy link
Contributor Author

yngyu commented Jan 28, 2022

rebase もしてあるのでマージします

@yngyu yngyu merged commit 3e77633 into develop Jan 28, 2022
@yngyu yngyu deleted the feature/fix_bce_command_prefix branch January 28, 2022 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers priority::medium priority medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants