generated from ut-issl/repository-template
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bce command prefix #221
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yngyu
added
good first issue
Good for newcomers
priority::medium
priority medium
labels
Jan 26, 2022
chutaro
approved these changes
Jan 26, 2022
...imum_user_for_s2e/src/src_user/Settings/TlmCmd/DataBase/CMD_DB/SAMPLE_MOBC_CMD_DB_CMD_DB.csv
Outdated
Show resolved
Hide resolved
余力があれば を直してもらいたい気持ちもあるけど,まあ,このドキュメントは今のままだと管理がだるすぎ,一新したい気持ちもあり,なので,わざわざ今更新しなくてもいい説はある. |
yngyu
force-pushed
the
feature/fix_bce_command_prefix
branch
from
January 27, 2022 14:38
f69f98b
to
85f6ca7
Compare
ドキュメントも更新しました |
meltingrabbit
approved these changes
Jan 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
よさそう
rebase もしてあるのでマージします |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
BCE コマンドの接頭辞を修正した
Issue
詳細
BCE コマンドの接頭辞を修正した. 合わせて
Cmd_BCT_NOP
は BCE ではないと思ったのでBCT側に移動させた検証結果
手元でpytestを一通り動かして通した
影響範囲
大 (BCに関連するので)