一時的なCTCPのtypedefを消し，各所のCTCPをCommonTlmCmdPacket, CommonTlmPacket, CommonCmdPacketのどれかに割り当てる #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meltingrabbit
added
enhancement
Merged
meltingrabbit
force-pushed
the
feature/delete_ctcp_typedef
branch
2 times, most recently
from
c8566b0 to
d476001
Compare
meltingrabbit
changed the title
meltingrabbit
force-pushed
the
feature/delete_ctcp_typedef
branch
from
2c0d599 to
9470fc2
Compare
yngyu
approved these changes
Jan 25, 2022
meltingrabbit
changed the base branch from
feature/divide_ctcp_to_ccp_and_ctp
to
develop
|
#209 がマージされたので rebase します． |
meltingrabbit
force-pushed
the
feature/delete_ctcp_typedef
branch
from
9470fc2 to
d06c4d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
一時的な
CTCPの typedef を消し，各所のCTCPをCommonTlmCmdPacket,CommonTlmPacket,CommonCmdPacketのどれかに割り当てるIssue
詳細
CTCPという型を消し去るCTCPは 適当にCommonTlmCmdPacket,CommonTlmPacket,CommonCmdPacketになおした．今後，これらが別の実体を指すようになった場合，ここで不適切だった修正はビルドエラーが出るはずなので，そのときに直す検証結果
既存のCIがすべて通ればOK
影響範囲
ここでは限定的．次に続くPRで大きな影響が出てくる見込み
備考
c2a-core/TlmCmd/packet_list.h
Lines 13 to 16 in e44058d
developに差し替えること！！！