Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

認証情報を環境変数から取得できるようにした #172

Merged
merged 3 commits into from
Jan 11, 2022
Merged

認証情報を環境変数から取得できるようにした #172

merged 3 commits into from
Jan 11, 2022

Conversation

yngyu
Copy link
Contributor

@yngyu yngyu commented Jan 7, 2022

概要

ひとことで

Issue

詳細

認証情報を環境変数から取得できるようにして、取得できた場合は authorization.json

検証結果

手元で test が動くことを確認した

補足

何かあれば

@yngyu yngyu added priority::low priority low tools labels Jan 7, 2022
@yngyu yngyu requested a review from meltingrabbit January 7, 2022 06:32
@yngyu yngyu self-assigned this Jan 7, 2022
meltingrabbit
meltingrabbit reviewed Jan 7, 2022
View reviewed changes
Examples/minimum_user_for_s2e/src/src_user/Test/utils/wings_utils.py Outdated
Comment on lines 9 to 13
client_id=os.environ.get("WINGS_CLIENT_ID"),
client_secret=os.environ.get("WINGS_CLIENT_SECRET"),
grant_type=os.environ.get("WINGS_GRANT_TYPE"),
username=os.environ.get("WINGS_USERNAME"),
password=os.environ.get("WINGS_PASSWORD")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

= の前後，スペース欲しいかも（ = 揃えまではしなくても良さそう（まあ，はよフォーマッタ入れろという話ではある）

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修正しました、が、python だとこれは無い方が多い気がします。 flake8 PEP8 E251

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

まじか～，じゃあなしでいきます？

一旦これで， #89 をたったとやりますね 🙏

@meltingrabbit
Copy link
Collaborator

[Q]

これ，手元ってwindows？

だとすると，環境変数は 普通に SETしたって感じ？

@yngyu
Copy link
Contributor Author

yngyu commented Jan 10, 2022

これは手元はwindowsでユーザー環境変数で手打ちでセットしてテストしました。

meltingrabbit
meltingrabbit approved these changes Jan 11, 2022
View reviewed changes
Copy link
Collaborator

@meltingrabbit meltingrabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

よさそう．

環境変数入れた場合，こっちでテストしてないけど，まあバグったらまたその時直しましょう．

@yngyu yngyu merged commit 99b697d into develop Jan 11, 2022
@yngyu yngyu deleted the feature/test_use_os_env branch January 11, 2022 14:12
@meltingrabbit meltingrabbit mentioned this pull request Feb 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meltingrabbit meltingrabbit meltingrabbit approved these changes

Assignees

@yngyu yngyu

Labels
priority::low priority low tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yngyu @meltingrabbit