EHでの二分探索をbsearchで書き直した #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
@yngyu バグ取れたんで，wip外しました．適当なときにreviewお願い 🙏 |
yngyu
reviewed
Dec 28, 2021
|
レビュー受けたので，テスト回し直します． |
yngyu
approved these changes
Dec 28, 2021
|
テスト再度通ったのでマージします． |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
EHでの二分探索をbsearchで書き直した
Issue
詳細
他にも，issueにある
範囲外アクセスの可能性ありそうも直した．検証結果
https://github.com/ut-issl/c2a-core/tree/fb90df7b9c178911c794611923e52a1d93d86f21/Examples/minimum_user_for_s2e/src/src_user/Test/test/src_core/System/EventManager
影響範囲
なし
補足
EHの改修が進んでいったら，1 eventで複数EH発火などもテストに入れたほうが良さそう