Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

図形クラスの問題文を解答例に合うように変えました #760

Merged
merged 2 commits into from
May 6, 2024

Conversation

kiyokaanan
Copy link
Contributor

No description provided.

@kiyokaanan kiyokaanan requested review from chvmvd and naka-12 May 5, 2024 02:34
Copy link

cloudflare-workers-and-pages bot commented May 5, 2024

Deploying utcode-learn with  Cloudflare Pages  Cloudflare Pages

Latest commit: 516eb65
Status: ✅  Deploy successful!
Preview URL: https://4e17c664.utcode-learn.pages.dev
Branch Preview URL: https://change-shape-class-question.utcode-learn.pages.dev

View logs

Copy link
Contributor

@aster-void aster-void left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


そして、`Shape` クラスを継承する `Rectangle` (長方形) クラス、`Square` (正方形) クラス、`Circle` (円) クラスを実装してみましょう。
そして、`Shape` クラスを継承し、面積を求める `calculateArea` メソッドを持つような、`Rectangle` (長方形) クラス、`Square` (正方形) クラス、`Circle` (円) クラスを実装してみましょう。また、コードが短くなるようにこの 3 つのクラスの間のどこで継承関係を作ればいいか考えてみましょう
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

コードが短くなるように、だけが目的ではない気がするので、あえて「コードが短くなるように」と言わなくてもいいかも?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ですね。

Copy link
Contributor

@chvmvd chvmvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これふつうに問題文間違ってましたね...(そういえば、これ授業直前にプルリクエストが来たやつだ...)
LGTM!

@kiyokaanan kiyokaanan merged commit e8dbab8 into master May 6, 2024
3 checks passed
@kiyokaanan kiyokaanan deleted the change-shape-class-question-sentence branch May 6, 2024 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants