イベントの演習のヒントを改訂 #726
Merged
イベントの演習のヒントを改訂 #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying utcode-learn with
|
| Latest commit: |
805caf0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://013ea2d9.utcode-learn.pages.dev |
| Branch Preview URL: | https://update-events-exercise-hints.utcode-learn.pages.dev |
chvmvd
reviewed
Apr 30, 2024
| @@ -83,30 +83,26 @@ greetButton.onclick = clicked(); | |||
|
|
|||
| <video src={projectMovieForDom} muted controls /> | |||
|
|
|||
| <Details summary={<summary>ヒント1：文字列の表示</summary>}> | |||
| :::tip[文字列の表示] | |||
There was a problem hiding this comment.
tipというよりは、ヒントなので、:::info[ヒント]で良いんじゃないでしょうか。
There was a problem hiding this comment.
うーん。tip のデフォルト値は「ヒント」で、info のデフォルト値は「備考」なんですけどね……
まあここでは一旦 :::info にしておいて、別PRで全体を置換するなりしたいなという感じです。
「文字列の表示」とした理由は、ヒントのブロックが2つ連続しているためです。まあ、:::info[ヒント: 文字列の表示] とかにしておきます。
There was a problem hiding this comment.
これは、Docusaurusの日本語訳の問題で、我々は英語の方に合わせるという方針で決定しました。
英語の意味的には、tipは豆知識という意味が強く、infoをヒントにする方が自然だという結論に達しました。詳細は、Notionを見てください。
naka-12
force-pushed
the
update-events-exercise-hints
branch
from
5948a0a to
805caf0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.