Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

データベースの節を読みやすく改善 #657

Merged
merged 2 commits into from
Dec 11, 2023
Merged

Conversation

chelproc
Copy link
Contributor

@chelproc chelproc commented Dec 2, 2023

closes #412

Copy link

cloudflare-workers-and-pages bot commented Dec 2, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0d38c55
Status: ✅  Deploy successful!
Preview URL: https://59b11f96.utcode-learn.pages.dev
Branch Preview URL: https://update-database.utcode-learn.pages.dev

View logs

@chelproc chelproc requested review from aster-void and chvmvd and removed request for aster-void December 2, 2023 08:17
Copy link
Contributor

@chvmvd chvmvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

82行目に演習という文字が残っています。課題の方にもかなり残っています。
ついでですが、npxコマンドのtipが正しくパースされていなさそうです。

docs/3-web-servers/07-database/index.mdx Outdated Show resolved Hide resolved
docs/3-web-servers/07-database/index.mdx Outdated Show resolved Hide resolved
docs/3-web-servers/07-database/index.mdx Outdated Show resolved Hide resolved
@chelproc chelproc requested a review from chvmvd December 7, 2023 10:13
Copy link
Contributor

@chvmvd chvmvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

いいですね!!
ウェブサーバーのあたりの課題はこれぐらい丁寧な手順があるとよいですよね。

@chelproc chelproc merged commit b8f1b68 into master Dec 11, 2023
3 checks passed
@chelproc chelproc deleted the update-database branch December 11, 2023 05:08
chvmvd added a commit that referenced this pull request Mar 30, 2024
#657 ではデータベースの解答のみしか修正されていなかったため、他の解答も #657 に合わせました。
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

レビュー反映
2 participants