Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOM の課題の追加 #519

Merged
merged 21 commits into from
Nov 2, 2023
Merged

DOM の課題の追加 #519

merged 21 commits into from
Nov 2, 2023

Conversation

aster-void
Copy link
Contributor

No description provided.

@aster-void
Copy link
Contributor Author

と appendChild、createElementの追加

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 28, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: d4a18e7
Status: ✅  Deploy successful!
Preview URL: https://b6d0792f.utcode-learn.pages.dev
Branch Preview URL: https://improve-dom-exercise.utcode-learn.pages.dev

View logs

@aster-void aster-void requested review from chvmvd and chelproc October 28, 2023 10:26
Copy link
Contributor

@chelproc chelproc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

普通にレビューしてみたのですがそもそもクラスもやっていない状況でここまでやる意味ありますかね?

docs/1-trial-session/13-dom/index.md Outdated Show resolved Hide resolved
docs/1-trial-session/13-dom/index.md Outdated Show resolved Hide resolved
docs/1-trial-session/13-dom/index.md Outdated Show resolved Hide resolved
docs/1-trial-session/13-dom/index.md Outdated Show resolved Hide resolved
docs/1-trial-session/13-dom/index.md Outdated Show resolved Hide resolved
docs/1-trial-session/13-dom/index.md Outdated Show resolved Hide resolved
docs/1-trial-session/13-dom/index.md Outdated Show resolved Hide resolved
docs/1-trial-session/13-dom/index.md Show resolved Hide resolved
docs/1-trial-session/13-dom/index.md Outdated Show resolved Hide resolved
@aster-void
Copy link
Contributor Author

普通にレビューしてみたのですがそもそもクラスもやっていない状況でここまでやる意味ありますかね?

クラスの課題を別のものにすることになって、クラス以外にToDoまでにDOMのメソッドの説明を入れるところがここくらいしかなかったです

@chvmvd
Copy link
Contributor

chvmvd commented Oct 28, 2023

DOMは非常に脱落者が多いところなのでこれ以上難しくしたくはないですね。とりあえず、おみくじまでは全員が到達して欲しいので。後は、クラスをやる前に説明すると後方参照が増えるのでなるべく避けたいという気持ちもあります。クラスのところも量を増やしたくはないけど、DOMよりはマシかなという感じだと思います。

@aster-void aster-void changed the title DOM の課題の改善 DOM の課題の追加 Oct 29, 2023
@aster-void
Copy link
Contributor Author

クラスの後に「DOM の提供するメソッド」みたいなセクションを作りますか?
DOMをこれ以上長くできないならこれが最善だと思いますが..

@chelproc
Copy link
Contributor

メモ: 10/30 のミーティングで Node#appendChild と document.createElement は DOM 側に統合することになった

docs/1-trial-session/13-dom/index.md Outdated Show resolved Hide resolved
docs/1-trial-session/13-dom/index.md Outdated Show resolved Hide resolved
docs/1-trial-session/13-dom/index.md Outdated Show resolved Hide resolved
docs/1-trial-session/13-dom/index.md Outdated Show resolved Hide resolved
docs/1-trial-session/13-dom/index.md Outdated Show resolved Hide resolved
docs/1-trial-session/13-dom/index.md Outdated Show resolved Hide resolved
docs/1-trial-session/13-dom/index.md Outdated Show resolved Hide resolved
docs/1-trial-session/13-dom/index.md Outdated Show resolved Hide resolved
docs/1-trial-session/13-dom/index.md Outdated Show resolved Hide resolved
docs/1-trial-session/13-dom/index.md Outdated Show resolved Hide resolved
docs/1-trial-session/13-dom/index.md Outdated Show resolved Hide resolved
docs/1-trial-session/13-dom/index.md Show resolved Hide resolved
@aster-void aster-void requested review from chelproc and chvmvd November 1, 2023 07:32
docs/1-trial-session/13-dom/index.md Outdated Show resolved Hide resolved
docs/1-trial-session/13-dom/index.md Outdated Show resolved Hide resolved
docs/1-trial-session/13-dom/index.md Outdated Show resolved Hide resolved
docs/1-trial-session/13-dom/index.md Outdated Show resolved Hide resolved
docs/1-trial-session/13-dom/index.md Outdated Show resolved Hide resolved
docs/1-trial-session/13-dom/index.md Outdated Show resolved Hide resolved
docs/1-trial-session/13-dom/index.md Show resolved Hide resolved
docs/1-trial-session/13-dom/index.md Outdated Show resolved Hide resolved
docs/1-trial-session/13-dom/index.md Outdated Show resolved Hide resolved
docs/1-trial-session/13-dom/index.md Outdated Show resolved Hide resolved
docs/1-trial-session/13-dom/index.md Outdated Show resolved Hide resolved
docs/1-trial-session/13-dom/index.md Outdated Show resolved Hide resolved
docs/1-trial-session/13-dom/index.md Outdated Show resolved Hide resolved
docs/1-trial-session/13-dom/index.md Outdated Show resolved Hide resolved
docs/1-trial-session/13-dom/index.md Outdated Show resolved Hide resolved
docs/1-trial-session/13-dom/index.md Outdated Show resolved Hide resolved
docs/1-trial-session/13-dom/index.md Outdated Show resolved Hide resolved
Comment on lines 75 to 77
const newElement = document.createElement("div");
newElement.textContent = "Hello World!";
parent.appendChild(newElement);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

newElement はさっき出てきたのでここで書く必要はないのでは?

docs/1-trial-session/13-dom/index.md Outdated Show resolved Hide resolved
docs/1-trial-session/13-dom/index.md Outdated Show resolved Hide resolved
docs/1-trial-session/13-dom/index.md Show resolved Hide resolved
@aster-void aster-void requested review from chelproc and chvmvd November 2, 2023 03:26
docs/1-trial-session/13-dom/index.md Outdated Show resolved Hide resolved
docs/1-trial-session/13-dom/index.md Outdated Show resolved Hide resolved
span 初出だと思うので、button のほうが良ければ revert してください。
Copy link
Contributor

@chelproc chelproc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

よさげですね!!!

Comment on lines +64 to +69
そして、`要素1.appendChild(要素2)` とすることで、要素1の子要素に要素2を追加し、画面に表示することができます。
今回は、`div` 要素の子要素にしてみましょう。

```html title="index.html"
<div id="parent-element"></div>
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

五月雨式で申し訳ないのですが、この部分このセクションの冒頭にあった方が良くないですかね?

この部分は HTML なのですでに知っている情報なので、この HTML を最初に提示した上で、どうやって子要素を追加するのか、というストーリーになるのがいいんじゃないでしょうか。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

書き方が難しいですが頑張ってみます

Copy link
Contributor Author

@aster-void aster-void Nov 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ストーリーの目的は、div 要素の子要素に追加することではなく新しい要素を作ることなので、最初に空の div 箱を作っておくよりここで作るほうが自然な感じがしました。
なのでここのほうがいいと思います

Copy link
Contributor

@chvmvd chvmvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

僕は良いと思います!!!!!!!

@aster-void
Copy link
Contributor Author

良さげならマージします!

@aster-void aster-void merged commit 74c70c6 into master Nov 2, 2023
@aster-void aster-void deleted the improve-dom-exercise branch November 2, 2023 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants