Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Answerタグの改善 #485

Merged
merged 3 commits into from
Oct 19, 2023
Merged

Answerタグの改善 #485

merged 3 commits into from
Oct 19, 2023

Conversation

aster-void
Copy link
Contributor

No description provided.

@aster-void
Copy link
Contributor Author

・解答は一つではないので 「解答例」に変更
・問題のタイトルをつけれるように (任意)

@aster-void aster-void requested a review from chvmvd October 18, 2023 15:41
Copy link
Contributor

@chvmvd chvmvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

引数は気になったけど、マージしてよいかと。

@@ -4,6 +4,14 @@ import Details from "@theme/Details";
/**
* component that hide an answer
*/
export default function Answer({ children }) {
return <Details summary={<summary>解答</summary>}>{children}</Details>;
export default function Answer({ type = undefined, children }) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typeというよりは、titleな気がする?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

この引数だけ見てもどういう引数かが、わからないんだよね...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

確かに

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

とりあえず、マージしてからでいいや。

@chvmvd
Copy link
Contributor

chvmvd commented Oct 19, 2023

マージする時は、こっちを先に!

@chvmvd
Copy link
Contributor

chvmvd commented Oct 19, 2023

そうすると、マージ先のブランチが自動で切り替わる。

@aster-void
Copy link
Contributor Author

マージします!

@aster-void aster-void merged commit f64832f into master Oct 19, 2023
@aster-void aster-void deleted the improve-answer-tag branch October 19, 2023 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants