-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Answerタグの改善 #485
Answerタグの改善 #485
Conversation
・解答は一つではないので 「解答例」に変更 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
引数は気になったけど、マージしてよいかと。
@@ -4,6 +4,14 @@ import Details from "@theme/Details"; | |||
/** | |||
* component that hide an answer | |||
*/ | |||
export default function Answer({ children }) { | |||
return <Details summary={<summary>解答</summary>}>{children}</Details>; | |||
export default function Answer({ type = undefined, children }) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
type
というよりは、titleな気がする?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
この引数だけ見てもどういう引数かが、わからないんだよね...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
確かに
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
とりあえず、マージしてからでいいや。
マージする時は、こっちを先に! |
そうすると、マージ先のブランチが自動で切り替わる。 |
マージします! |
No description provided.