Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "fix critical typo" #419

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Revert "fix critical typo" #419

merged 1 commit into from
Oct 6, 2023

Conversation

chvmvd
Copy link
Contributor

@chvmvd chvmvd commented Oct 5, 2023 •
edited
Loading

  • URIエンコードということばは存在しないため、戻した。

@chvmvd
Revert "fix critical typo"
b349637 
This reverts commit 95d58f2.
@chvmvd chvmvd requested a review from aster-void October 5, 2023 09:31
@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: b349637
Status: ✅  Deploy successful!
Preview URL: https://8530c256.utcode-learn.pages.dev
Branch Preview URL: https://revert-from-uri-to-url.utcode-learn.pages.dev

View logs

@chvmvd chvmvd mentioned this pull request Oct 5, 2023
Closed
3 tasks
@aster-void
Copy link
Contributor

URLエンコードでも関数はencodeURIであることは強調しておきたいですね

@chvmvd
Copy link
Contributor Author

chvmvd commented Oct 5, 2023

まあ、tipなので、これぐらいやる人なら、自分でエラーの原因わかるかなと。

aster-void
aster-void approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@aster-void aster-void left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@chvmvd chvmvd merged commit 3034d87 into master Oct 6, 2023
@chvmvd chvmvd deleted the revert-from-uri-to-url branch October 6, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aster-void aster-void aster-void approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chvmvd @aster-void