Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon purge? #205

Closed
annez opened this issue Nov 2, 2016 · 5 comments
Closed

Icon purge? #205

annez opened this issue Nov 2, 2016 · 5 comments

Comments

@annez
Copy link
Contributor

annez commented Nov 2, 2016

We currently have quite a few unused icons in our repository. Would be good to purge ones we do not use.

Main reasons:

  • SVGs are 327kb non-gzipped
  • they are the biggest file being served on uSwitch, before the fonts.

If we come up with a better solution on doing the icons, then we should go with that.

@annez
Copy link
Contributor Author

annez commented Nov 11, 2016

Unused icons (from github search)

  • android
  • angry
  • apple
  • arrow-up-left
  • barchart
  • blackberry
  • desktop
  • doc
  • github (only used in ustyle)
  • happy
  • laptop
  • magnify-out
  • neutral (only used in accounts hub test)
  • power
  • question
  • sad
  • tablet
  • warning
  • windows
  • wondering
  • world
  • controller

@ricardomccerqueira
Copy link
Contributor

I Agree with this, just probably need people to go through their verticals and make sure we don't need any of these.
From your list, I know in mobiles we need:

  • android
  • apple
  • windows
  • blackberry

I defend that stuff should only be in uStyle if it's shared, so if it's only used within mobiles, I'm very happy to cater for them myself

@annez
Copy link
Contributor Author

annez commented Dec 12, 2016

@ricardomccerqueira Can you clarify that those are internal icons you are using are you are indeed using the ustyle icons?

@ricardomccerqueira
Copy link
Contributor

mobiles-web is using a separate version of those Icons:
https://github.com/uswitch/mobiles-web/blob/master/app/assets/stylesheets/components/_svg-icons.sass#L70

Feel free to delete them from uStyle if you want.

@greenie
Copy link
Contributor

greenie commented Dec 12, 2016

@annez We don't use any of the icons that you mentioned in your second comment. We do use --smiley instead of --happy however.

annez pushed a commit that referenced this issue Dec 12, 2016
annez added a commit that referenced this issue Dec 19, 2016
Removing icons listed in #205 - fixes
@annez annez closed this as completed Dec 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants