Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GHA CI/CD checkout for corrected version string #180

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

aj-stein-nist
Copy link
Collaborator

@aj-stein-nist aj-stein-nist commented Aug 15, 2023

Committer Notes

Currently, the locally built copies of the oscal-cli utility does
correctly encode version information based on short ID for commits and
tags. This behavior functions correctly because the git clone for
normal operations retrieves full history so you can properly analyze
commits and find the latest tag.

This behavior does not work with the default behavior (and arguments),
as of actions/checkout@c85c95e, does
not get that history. This commit configures GitHub CI/CD with this
action to fetch the full history of the repo to do it correctly.

See usnistgov/liboscal-java#173 for details.

All Submissions:

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all website and readme documentation affected by the changes you made?

@aj-stein-nist aj-stein-nist added this to the Next milestone Aug 15, 2023
@aj-stein-nist aj-stein-nist self-assigned this Aug 15, 2023
@aj-stein-nist aj-stein-nist marked this pull request as ready for review August 15, 2023 20:48
@aj-stein-nist aj-stein-nist changed the base branch from main to develop August 15, 2023 20:49
Copy link
Collaborator

@david-waltermire david-waltermire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Currently, the locally built copies of the oscal-cli utility does
correctly encode version information based on short ID for commits and
tags. This behavior functions correctly because the git clone for
normal operations retrieves full history so you can properly analyze
commits and find the latest tag.

This behavior does not work with the default behavior (and arguments),
as of actions/checkout@c85c95e, does
not get that history. This commit configures GitHub CI/CD with this
action to fetch the full history of the repo to do it correctly.

See usnistgov/liboscal-java#173 for details.
@aj-stein-nist aj-stein-nist force-pushed the chore-update-checkout-version-string branch from e70846a to 05a9b86 Compare August 15, 2023 20:55
@aj-stein-nist aj-stein-nist merged commit 178ed67 into develop Aug 15, 2023
@aj-stein-nist aj-stein-nist removed this from the Next milestone Sep 28, 2023
@aj-stein-nist aj-stein-nist deleted the chore-update-checkout-version-string branch November 30, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants