Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct OSCAL version handling in resolved profile #21

Merged
merged 2 commits into from
May 18, 2022
Merged

Correct OSCAL version handling in resolved profile #21

merged 2 commits into from
May 18, 2022

Conversation

david-waltermire
Copy link
Collaborator

@david-waltermire david-waltermire commented May 17, 2022 •
edited
Loading

Committer Notes

Corrected metadata/oscal-version handling bug to use OSCAL version, not the content version from a source profile. Resolves #15.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all website and readme documentation affected by the changes you made?

aj-stein-nist
aj-stein-nist previously approved these changes May 17, 2022
View reviewed changes
@david-waltermire david-waltermire force-pushed the develop branch 2 times, most recently from c614992 to 1de0aeb Compare May 17, 2022 23:26
@david-waltermire
Corrected metadata/oscal-version handling bug to use OSCAL version, n…
efe7bec 
…ot the content version from a source profile. Resolves usnistgov#15.
@david-waltermire
More adjustments to handling of version and OSCAL version. Version is…
224b8c1 
… not the version of the profile. OSCAL version is the high water mark of the profile, plus any imports.
@david-waltermire david-waltermire linked an issue May 18, 2022 that may be closed by this pull request
Profile resolution incorrectly maps the oscal-version from the version on the source profile #15
Closed
@david-waltermire david-waltermire merged commit 901ba61 into usnistgov:develop May 18, 2022
@david-waltermire david-waltermire deleted the issue15-fix-version branch May 18, 2022 13:50
@david-waltermire david-waltermire mentioned this pull request May 20, 2022
Closed
12 tasks
david-waltermire added a commit that referenced this pull request Jun 21, 2022
@david-waltermire
Correct OSCAL version handling in resolved profile (#21)
4fd38f5 
* Corrected metadata/oscal-version handling bug to use OSCAL version, not the content version from a source profile. Resolves #15.
* More adjustments to handling of version and OSCAL version. OSCAL version is the high water mark of the profile, plus any imports. See usnistgov/OSCAL#1272.
david-waltermire added a commit that referenced this pull request Jun 24, 2022
@david-waltermire
Correct OSCAL version handling in resolved profile (#21)
88c8712 
* Corrected metadata/oscal-version handling bug to use OSCAL version, not the content version from a source profile. Resolves #15.
* More adjustments to handling of version and OSCAL version. OSCAL version is the high water mark of the profile, plus any imports. See usnistgov/OSCAL#1272.
david-waltermire added a commit to david-waltermire/liboscal-java that referenced this pull request Jun 29, 2022
@david-waltermire
Correct OSCAL version handling in resolved profile (usnistgov#21)
7cfda49 
* Corrected metadata/oscal-version handling bug to use OSCAL version, not the content version from a source profile. Resolves usnistgov#15.
* More adjustments to handling of version and OSCAL version. OSCAL version is the high water mark of the profile, plus any imports. See usnistgov/OSCAL#1272.
david-waltermire added a commit that referenced this pull request Jun 29, 2022
@david-waltermire
Correct OSCAL version handling in resolved profile (#21)
8722a2b 
* Corrected metadata/oscal-version handling bug to use OSCAL version, not the content version from a source profile. Resolves #15.
* More adjustments to handling of version and OSCAL version. OSCAL version is the high water mark of the profile, plus any imports. See usnistgov/OSCAL#1272.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aj-stein-nist aj-stein-nist aj-stein-nist left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Profile resolution incorrectly maps the oscal-version from the version on the source profile
2 participants
@david-waltermire @aj-stein-nist