Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate pkg_resources to importlib #945

Merged
merged 3 commits into from
Sep 1, 2023
Merged

Conversation

guyer
Copy link
Member

@guyer guyer commented Aug 31, 2023

pkg_resources is deprecated, but importlib.resources requires Python 3.7 and importlib.metadata requires Python 3.8.

Fixes #944

@guyer
Copy link
Member Author

guyer commented Sep 1, 2023

Important

pkg_resources still used in fipy.tests.test().
It's unclear what the modern equivalent is of EntryPoint.parse() and, anyway, all of this raises

WARNING: Testing via this command is deprecated and will be removed in a future version. Users looking for a generic test entry point independent of test runner are encouraged to use tox.

@guyer guyer requested review from wd15 and tkphd September 1, 2023 13:20
@guyer guyer merged commit edd82b6 into master Sep 1, 2023
16 of 23 checks passed
@guyer guyer deleted the migrate_pkg_resources2importlib branch September 1, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Having problem with Viewer
2 participants