-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace deprecated numpy types #798
Conversation
Remaining failures are unrelated to this PR:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable. I have not tested locally, but confirmed that the CI errors are unrelated. LGTM.
As of NumPy 1.20, skfmm warns "`np.int` is a deprecated alias for the builtin `int`". This has been [fixed](scikit-fmm/scikit-fmm@4c98944) but hasn't percolted to PyPI, yet.
tvtk warns "Converting `np.character` to a dtype is deprecated." We'll hopefully be getting rid of dependency on tvtk altogether
tvtk warns "'TraitPrefixMap' trait handler has been deprecated". We'll hopefully be getting rid of dependency on tvtk altogether
I've added more changes of the same character, although in these cases, the deprecations are not in our code, so I've silenced the errors in the tests, rather than doing anything useful to make the deprecation go away.
|
A better picture of the test status can be seen in the integration tests at #799 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All checks pass in #799. Yeet those types.
Recent NumPy versions (~1.20) raise a number of deprecation warnings:
np.bool
is a deprecated alias for the builtinbool
" infipy.variables.variable
np.int
is a deprecated alias for the builtinint
" inskfmm
np.character
to a dtype is deprecated" intvtk
tvtk