Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stop divide by zero warning in LU solvers #790

Merged
merged 3 commits into from
Nov 29, 2021

Conversation

wd15
Copy link
Contributor

@wd15 wd15 commented Mar 22, 2021

Prompted by this.

Stop the divide by zero warning in LU solvers by rearranging the
tolerance check.
@wd15
Copy link
Contributor Author

wd15 commented Mar 22, 2021

Test failures seem unrelated to changes

@wd15 wd15 marked this pull request as ready for review March 22, 2021 21:30
shell.nix Outdated
@@ -31,7 +31,12 @@ in

export OMPI_MCA_plm_rsh_agent=/usr/bin/ssh

## To build the docs
## To build the docs (don't use --pure)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this go in #791?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@wd15 wd15 marked this pull request as draft March 23, 2021 12:56
@wd15
Copy link
Contributor Author

wd15 commented Mar 24, 2021

VTK failure on Travis is probably version incompatibility with Numpy.

@guyer
Copy link
Member

guyer commented Mar 24, 2021

I agree, the VTK errors are safe to ignore

@guyer
Copy link
Member

guyer commented Mar 24, 2021

I don't understand why the polyxtal example is stalling with SciPy on Py3k

@wd15
Copy link
Contributor Author

wd15 commented Mar 24, 2021

I don't understand why the polyxtal example is stalling with SciPy on Py3k

Is this the first time you've seen that?

@guyer
Copy link
Member

guyer commented Mar 24, 2021

I can't remember a stall like this for a serial run. I was wondering if the error was somehow negative, so that the <= test would fail, but I don't think that's possible and I don't know why that would make it stall.

@wd15
Copy link
Contributor Author

wd15 commented Mar 24, 2021

I can't remember a stall like this for a serial run. I was wondering if the error was somehow negative, so that the <= test would fail, but I don't think that's possible and I don't know why that would make it stall.

Not to worry. I'll try and debug it at some point. No rush to finish this.

@guyer
Copy link
Member

guyer commented Apr 9, 2021

polyxtal is stalling with SciPy on other branches. This doesn't have anything to do with it.

@wd15
Copy link
Contributor Author

wd15 commented Sep 13, 2021

@guyer I merged from master and tests are failing for various reasons seemingly not related to the changes.

@guyer
Copy link
Member

guyer commented Sep 13, 2021

@guyer I merged from master and tests are failing for various reasons seemingly not related to the changes.

Weird. Looks like a slew of unrelated failures. Should be a joy to debug.

@guyer
Copy link
Member

guyer commented Sep 17, 2021

Looks like a lot of things started failing about 5 months ago when I relaxed the installation constraint on Gmsh from "gmsh<4.0" to just gmsh. (see #820)

@guyer guyer marked this pull request as ready for review November 29, 2021 21:50
@guyer guyer merged commit ba1d470 into usnistgov:master Nov 29, 2021
@wd15 wd15 deleted the lu-divide-by-zero branch June 28, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants