Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document behavior when d{xyz} is a list #654

Merged
merged 3 commits into from
Jun 14, 2019
Merged

Document behavior when d{xyz} is a list #654

merged 3 commits into from
Jun 14, 2019

Conversation

guyer
Copy link
Member

@guyer guyer commented Jun 13, 2019

FIx #458

@guyer guyer requested review from tkphd and wd15 June 13, 2019 23:34
tkphd
tkphd requested changes Jun 14, 2019
View reviewed changes
Copy link
Contributor

@tkphd tkphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please represent sets with delimiters. Commas are cheap.

L{xyz} → L{x,y,z}, etc.

fipy/meshes/factoryMeshes.py Outdated Show resolved Hide resolved
@guyer guyer requested a review from tkphd June 14, 2019 17:56
@guyer guyer merged commit dd23846 into usnistgov:master Jun 14, 2019
@guyer guyer deleted the issue458-Documentation_wrong_for_precedence_of_Lx_and_dx_for_NonUniformGrids branch June 14, 2019 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkphd tkphd tkphd approved these changes

@wd15 wd15 Awaiting requested review from wd15

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation wrong for precedence of 'Lx' and 'dx' for NonUniformGrids
2 participants
@guyer @tkphd