Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A variety of website updates #653

Merged

Conversation

david-waltermire
Copy link
Contributor

@david-waltermire david-waltermire commented Apr 17, 2020

Committer Notes

This PR contains the following updates:

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all OSCAL website and readme documentation affected by the changes you made? Changes to the OSCAL website can be made in the docs/content directory of your branch.

@david-waltermire david-waltermire marked this pull request as ready for review April 20, 2020 18:33
wendellpiez
wendellpiez previously approved these changes Apr 22, 2020
Copy link
Contributor

@wendellpiez wendellpiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not essential but nice: put the left nav / ToC into the same order as the diagram on the /documentation/schema page.

In general, it looks great --

@david-waltermire david-waltermire linked an issue Apr 23, 2020 that may be closed by this pull request
5 tasks
Added web page description to the roadmap page.
@david-waltermire
Copy link
Contributor Author

Addressed review feedback.

@david-waltermire david-waltermire merged commit 6411e4f into usnistgov:master Apr 23, 2020
david-waltermire pushed a commit that referenced this pull request Apr 23, 2020
@david-waltermire david-waltermire deleted the website-maintenance branch April 23, 2020 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants