Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Path for Schematron Validation of Metaschema Models #1108

Merged
merged 2 commits into from
Jan 25, 2022
Merged

Update Path for Schematron Validation of Metaschema Models #1108

merged 2 commits into from
Jan 25, 2022

Conversation

aj-stein-nist
Copy link
Contributor

@aj-stein-nist aj-stein-nist commented Jan 25, 2022 •
edited
Loading

Committer Notes

This PR implements some useful touch-ups that is part, but potentially not all of #1107.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all OSCAL website and readme documentation affected by the changes you made? Changes to the OSCAL website can be made in the docs/content directory of your branch.

@aj-stein-nist aj-stein-nist changed the title Update xml-model PI with updated @href for Schematron validation. Update Path for Schematron Validation of Metaschema Models Jan 25, 2022
david-waltermire
david-waltermire approved these changes Jan 25, 2022
View reviewed changes
Copy link
Contributor

@david-waltermire david-waltermire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@david-waltermire david-waltermire merged commit 094ba23 into release-1.0 Jan 25, 2022
@david-waltermire david-waltermire deleted the issue-1107-metaschema-schematron-fixes branch January 25, 2022 22:09
@aj-stein-nist aj-stein-nist linked an issue Jan 25, 2022 that may be closed by this pull request
Metaschema Schematron Validation Checks Issues #1107
Closed
@aj-stein-nist aj-stein-nist mentioned this pull request Jan 25, 2022
Closed
david-waltermire pushed a commit that referenced this pull request Jan 26, 2022
@aj-stein-nist @david-waltermire
Update Path for Schematron Validation of Metaschema Models (#1108)
5fa55c7 
* Update xml-model PI with updated @href for Schematron validation.
* Per feedback from Dave uncomment PI for complete schema
iMichaela pushed a commit to iMichaela/OSCAL that referenced this pull request Apr 7, 2022
@aj-stein-nist @iMichaela
Update Path for Schematron Validation of Metaschema Models (usnistgov…
7d84e0e 
…#1108)

* Update xml-model PI with updated @href for Schematron validation.
* Per feedback from Dave uncomment PI for complete schema
Rene2mt pushed a commit to Rene2mt/OSCAL that referenced this pull request May 17, 2022
@aj-stein-nist @Rene2mt
Update Path for Schematron Validation of Metaschema Models (usnistgov…
101b9da 
…#1108)

* Update xml-model PI with updated @href for Schematron validation.
* Per feedback from Dave uncomment PI for complete schema
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-waltermire david-waltermire david-waltermire approved these changes

@wendellpiez wendellpiez Awaiting requested review from wendellpiez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Metaschema Schematron Validation Checks Issues
2 participants
@aj-stein-nist @david-waltermire