Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Submit Model docs feedback on profile model #1392

Closed
3 tasks
wendellpiez opened this issue Jul 28, 2022 · 1 comment
Closed
3 tasks

Submit Model docs feedback on profile model #1392

wendellpiez opened this issue Jul 28, 2022 · 1 comment
Assignees
@wendellpiez
Labels
enhancement User Story
Milestone
v1.1.0

Comments

@wendellpiez
Copy link
Contributor

User Story

Make a PR addressing feedback to models here: https://hackmd.io/D4W1e9bnSpq797myjrJVyQ

See #1331. PR should be to the branch behind #1263.

Goals

Integrate revisions to models documentation.

Dependencies

none

Acceptance Criteria

  • All OSCAL website and readme documentation affected by the changes in this issue have been updated. Changes to the OSCAL website can be made in the docs/content directory of your branch.
  • A Pull Request (PR) is submitted that fully addresses the goals of this User Story. This issue is referenced in the PR.
  • The CI-CD build process runs without any reported errors on the PR. This can be confirmed by reviewing that all checks have passed in the PR.
wendellpiez added a commit to wendellpiez/OSCAL that referenced this issue Jul 29, 2022
@wendellpiez
Addressing usnistgov#1392 wish me luck
9cea74e
@wendellpiez wendellpiez mentioned this issue Jul 29, 2022
Merged
9 tasks
@david-waltermire david-waltermire added this to the OSCAL 1.1.0 milestone Aug 1, 2022
david-waltermire pushed a commit to wendellpiez/OSCAL that referenced this issue Aug 12, 2022
@wendellpiez @david-waltermire
Addressing usnistgov#1392 wish me luck
1135ad8
david-waltermire added a commit to david-waltermire/OSCAL that referenced this issue Aug 12, 2022
@wendellpiez @david-waltermire
Proposed metaschema docs updates (#50)
a8c12d9 
* Feedback based on usnistgov#1392
* Adjustments based on model review feedback on 8/12.
* Removed outdated merge phase remarks. Created issue #53 to address this.

Co-authored-by: David Waltermire <david.waltermire@nist.gov>
@wendellpiez wendellpiez moved this from Todo to Under Review in NIST OSCAL Work Board Aug 15, 2022
@david-waltermire
Copy link
Contributor

Merged this with PR david-waltermire#50.

Repository owner moved this from Under Review to Done in NIST OSCAL Work Board Aug 15, 2022
david-waltermire added a commit to david-waltermire/OSCAL that referenced this issue Aug 19, 2022
@wendellpiez @david-waltermire
Proposed metaschema docs updates (#50)
2c306f8 
* Feedback based on usnistgov#1392
* Adjustments based on model review feedback on 8/12.
* Removed outdated merge phase remarks. Created issue #53 to address this.

Co-authored-by: David Waltermire <david.waltermire@nist.gov>
david-waltermire added a commit to david-waltermire/OSCAL that referenced this issue Aug 22, 2022
@wendellpiez @david-waltermire
Proposed metaschema docs updates (#50)
dfd6cfd 
* Feedback based on usnistgov#1392
* Adjustments based on model review feedback on 8/12.
* Removed outdated merge phase remarks. Created issue #53 to address this.

Co-authored-by: David Waltermire <david.waltermire@nist.gov>
david-waltermire added a commit to david-waltermire/OSCAL that referenced this issue Aug 23, 2022
@wendellpiez @david-waltermire
Proposed metaschema docs updates (#50)
f98dfa9 
* Feedback based on usnistgov#1392
* Adjustments based on model review feedback on 8/12.
* Removed outdated merge phase remarks. Created issue #53 to address this.

Co-authored-by: David Waltermire <david.waltermire@nist.gov>
david-waltermire added a commit to david-waltermire/OSCAL that referenced this issue Aug 23, 2022
@wendellpiez @david-waltermire
Proposed metaschema docs updates (#50)
436f255 
* Feedback based on usnistgov#1392
* Adjustments based on model review feedback on 8/12.
* Removed outdated merge phase remarks. Created issue #53 to address this.

Co-authored-by: David Waltermire <david.waltermire@nist.gov>
david-waltermire added a commit to david-waltermire/OSCAL that referenced this issue Sep 26, 2022
@wendellpiez @david-waltermire
Proposed metaschema docs updates (#50)
5f5a693 
* Feedback based on usnistgov#1392
* Adjustments based on model review feedback on 8/12.
* Removed outdated merge phase remarks. Created issue #53 to address this.

Co-authored-by: David Waltermire <david.waltermire@nist.gov>
david-waltermire added a commit that referenced this issue Sep 27, 2022
@david-waltermire @aj-stein-nist
@wendellpiez @Rene2mt
Updates to OSCAL Metaschema documentation and constraints (#1263)
39477fd 
* completed partial update of the Metadata object documentation.
* adjustments to roles
* adjusted the cardinality of location/address to make address optional.
* Improved documentation and constraints related to location and parties
* addressed the remainder of metadata and control feedback from @Rene2mt.
* Improved the introductory remarks for a profile to better describe what a profile is and what it does.
* Fixed a broken constraint that was not targeting the right node.
* started refining descriptions and adding properties to describe identifier attributes.
* Addressed feedback from AJ during 20220718-20220722. (#48)
* Week 30 feedback on SSP model. (#49)
* Proposed metaschema docs updates (#50)
* Addressed feedback based on #1392
* Adjustments based on model review feedback on 8/12.
* Removed outdated merge phase remarks. Created issue #53 to address this.
* Addressed A.J. Stein's Week 32 Feedback for Model Review (#52)
* Addressed AJ Stein's week 32 feedback for #1331.
* Addressed DRAFT: Update catalog & profile metaschema documentation (#51)
* Update catalog & profile metaschema documentation
* Add props to control identifier
* Fixed broken syntax and addressed consistency in wording within the Profile 'merge' construct.
* Adjustments to alter, moving to to an inline definition
* cleaned up empty remark.
* Removed redundant constraints
* removed some redundant constraints
* Preliminary work on URI documentation to address #1249.
* More work on document URI use in OSCAL
* Updating data types related to usnistgov/metaschema#224.
* Improved consistency of how URI concepts are discussed.
* Added note about party locations
* Updated Metaschema instances of `uri` and `uri-reference` data types to indicate their URI semantics. Resolves #1249.
* Added identifier props to control layer metaschemas (#55)
* Responding to #1066: metaschema edits; CSS enhancement (#56)
* Whitespace cleanup in metadata metaschema
* Apply suggestions from code review

Co-authored-by: Alexander Stein <alexander.stein@nist.gov>
Co-authored-by: Wendell Piez <wapiez@wendellpiez.com>
Co-authored-by: Rene Tshiteya <rene-claude.tshiteya@gsa.gov>
aj-stein-nist added a commit that referenced this issue Oct 18, 2022
@david-waltermire @aj-stein-nist
@wendellpiez @Rene2mt
Updates to OSCAL Metaschema documentation and constraints (#1263)
52b81c9 
* completed partial update of the Metadata object documentation.
* adjustments to roles
* adjusted the cardinality of location/address to make address optional.
* Improved documentation and constraints related to location and parties
* addressed the remainder of metadata and control feedback from @Rene2mt.
* Improved the introductory remarks for a profile to better describe what a profile is and what it does.
* Fixed a broken constraint that was not targeting the right node.
* started refining descriptions and adding properties to describe identifier attributes.
* Addressed feedback from AJ during 20220718-20220722. (#48)
* Week 30 feedback on SSP model. (#49)
* Proposed metaschema docs updates (#50)
* Addressed feedback based on #1392
* Adjustments based on model review feedback on 8/12.
* Removed outdated merge phase remarks. Created issue #53 to address this.
* Addressed A.J. Stein's Week 32 Feedback for Model Review (#52)
* Addressed AJ Stein's week 32 feedback for #1331.
* Addressed DRAFT: Update catalog & profile metaschema documentation (#51)
* Update catalog & profile metaschema documentation
* Add props to control identifier
* Fixed broken syntax and addressed consistency in wording within the Profile 'merge' construct.
* Adjustments to alter, moving to to an inline definition
* cleaned up empty remark.
* Removed redundant constraints
* removed some redundant constraints
* Preliminary work on URI documentation to address #1249.
* More work on document URI use in OSCAL
* Updating data types related to usnistgov/metaschema#224.
* Improved consistency of how URI concepts are discussed.
* Added note about party locations
* Updated Metaschema instances of `uri` and `uri-reference` data types to indicate their URI semantics. Resolves #1249.
* Added identifier props to control layer metaschemas (#55)
* Responding to #1066: metaschema edits; CSS enhancement (#56)
* Whitespace cleanup in metadata metaschema
* Apply suggestions from code review

Co-authored-by: Alexander Stein <alexander.stein@nist.gov>
Co-authored-by: Wendell Piez <wapiez@wendellpiez.com>
Co-authored-by: Rene Tshiteya <rene-claude.tshiteya@gsa.gov>
david-waltermire added a commit that referenced this issue Oct 31, 2022
@david-waltermire @aj-stein-nist
@wendellpiez @Rene2mt
Updates to OSCAL Metaschema documentation and constraints (#1263)
6f775a4 
* completed partial update of the Metadata object documentation.
* adjustments to roles
* adjusted the cardinality of location/address to make address optional.
* Improved documentation and constraints related to location and parties
* addressed the remainder of metadata and control feedback from @Rene2mt.
* Improved the introductory remarks for a profile to better describe what a profile is and what it does.
* Fixed a broken constraint that was not targeting the right node.
* started refining descriptions and adding properties to describe identifier attributes.
* Addressed feedback from AJ during 20220718-20220722. (#48)
* Week 30 feedback on SSP model. (#49)
* Proposed metaschema docs updates (#50)
* Addressed feedback based on #1392
* Adjustments based on model review feedback on 8/12.
* Removed outdated merge phase remarks. Created issue #53 to address this.
* Addressed A.J. Stein's Week 32 Feedback for Model Review (#52)
* Addressed AJ Stein's week 32 feedback for #1331.
* Addressed DRAFT: Update catalog & profile metaschema documentation (#51)
* Update catalog & profile metaschema documentation
* Add props to control identifier
* Fixed broken syntax and addressed consistency in wording within the Profile 'merge' construct.
* Adjustments to alter, moving to to an inline definition
* cleaned up empty remark.
* Removed redundant constraints
* removed some redundant constraints
* Preliminary work on URI documentation to address #1249.
* More work on document URI use in OSCAL
* Updating data types related to usnistgov/metaschema#224.
* Improved consistency of how URI concepts are discussed.
* Added note about party locations
* Updated Metaschema instances of `uri` and `uri-reference` data types to indicate their URI semantics. Resolves #1249.
* Added identifier props to control layer metaschemas (#55)
* Responding to #1066: metaschema edits; CSS enhancement (#56)
* Whitespace cleanup in metadata metaschema
* Apply suggestions from code review

Co-authored-by: Alexander Stein <alexander.stein@nist.gov>
Co-authored-by: Wendell Piez <wapiez@wendellpiez.com>
Co-authored-by: Rene Tshiteya <rene-claude.tshiteya@gsa.gov>
aj-stein-nist added a commit to aj-stein-nist/OSCAL-forked that referenced this issue Jan 10, 2023
@david-waltermire @aj-stein-nist
@wendellpiez @Rene2mt
Updates to OSCAL Metaschema documentation and constraints (usnistgov#…
d1902c3 
…1263)

* completed partial update of the Metadata object documentation.
* adjustments to roles
* adjusted the cardinality of location/address to make address optional.
* Improved documentation and constraints related to location and parties
* addressed the remainder of metadata and control feedback from @Rene2mt.
* Improved the introductory remarks for a profile to better describe what a profile is and what it does.
* Fixed a broken constraint that was not targeting the right node.
* started refining descriptions and adding properties to describe identifier attributes.
* Addressed feedback from AJ during 20220718-20220722. (#48)
* Week 30 feedback on SSP model. (#49)
* Proposed metaschema docs updates (#50)
* Addressed feedback based on usnistgov#1392
* Adjustments based on model review feedback on 8/12.
* Removed outdated merge phase remarks. Created issue #53 to address this.
* Addressed A.J. Stein's Week 32 Feedback for Model Review (#52)
* Addressed AJ Stein's week 32 feedback for usnistgov#1331.
* Addressed DRAFT: Update catalog & profile metaschema documentation (#51)
* Update catalog & profile metaschema documentation
* Add props to control identifier
* Fixed broken syntax and addressed consistency in wording within the Profile 'merge' construct.
* Adjustments to alter, moving to to an inline definition
* cleaned up empty remark.
* Removed redundant constraints
* removed some redundant constraints
* Preliminary work on URI documentation to address usnistgov#1249.
* More work on document URI use in OSCAL
* Updating data types related to usnistgov/metaschema#224.
* Improved consistency of how URI concepts are discussed.
* Added note about party locations
* Updated Metaschema instances of `uri` and `uri-reference` data types to indicate their URI semantics. Resolves usnistgov#1249.
* Added identifier props to control layer metaschemas (#55)
* Responding to usnistgov#1066: metaschema edits; CSS enhancement (#56)
* Whitespace cleanup in metadata metaschema
* Apply suggestions from code review

Co-authored-by: Alexander Stein <alexander.stein@nist.gov>
Co-authored-by: Wendell Piez <wapiez@wendellpiez.com>
Co-authored-by: Rene Tshiteya <rene-claude.tshiteya@gsa.gov>
aj-stein-nist added a commit to aj-stein-nist/OSCAL-forked that referenced this issue Feb 6, 2023
@david-waltermire @aj-stein-nist
@wendellpiez @Rene2mt
Updates to OSCAL Metaschema documentation and constraints (usnistgov#…
f5a03e7 
…1263)

* completed partial update of the Metadata object documentation.
* adjustments to roles
* adjusted the cardinality of location/address to make address optional.
* Improved documentation and constraints related to location and parties
* addressed the remainder of metadata and control feedback from @Rene2mt.
* Improved the introductory remarks for a profile to better describe what a profile is and what it does.
* Fixed a broken constraint that was not targeting the right node.
* started refining descriptions and adding properties to describe identifier attributes.
* Addressed feedback from AJ during 20220718-20220722. (#48)
* Week 30 feedback on SSP model. (#49)
* Proposed metaschema docs updates (#50)
* Addressed feedback based on usnistgov#1392
* Adjustments based on model review feedback on 8/12.
* Removed outdated merge phase remarks. Created issue #53 to address this.
* Addressed A.J. Stein's Week 32 Feedback for Model Review (#52)
* Addressed AJ Stein's week 32 feedback for usnistgov#1331.
* Addressed DRAFT: Update catalog & profile metaschema documentation (#51)
* Update catalog & profile metaschema documentation
* Add props to control identifier
* Fixed broken syntax and addressed consistency in wording within the Profile 'merge' construct.
* Adjustments to alter, moving to to an inline definition
* cleaned up empty remark.
* Removed redundant constraints
* removed some redundant constraints
* Preliminary work on URI documentation to address usnistgov#1249.
* More work on document URI use in OSCAL
* Updating data types related to usnistgov/metaschema#224.
* Improved consistency of how URI concepts are discussed.
* Added note about party locations
* Updated Metaschema instances of `uri` and `uri-reference` data types to indicate their URI semantics. Resolves usnistgov#1249.
* Added identifier props to control layer metaschemas (#55)
* Responding to usnistgov#1066: metaschema edits; CSS enhancement (#56)
* Whitespace cleanup in metadata metaschema
* Apply suggestions from code review

Co-authored-by: Alexander Stein <alexander.stein@nist.gov>
Co-authored-by: Wendell Piez <wapiez@wendellpiez.com>
Co-authored-by: Rene Tshiteya <rene-claude.tshiteya@gsa.gov>
aj-stein-nist added a commit to aj-stein-nist/OSCAL-forked that referenced this issue Jun 29, 2023
@david-waltermire @aj-stein-nist
@wendellpiez @Rene2mt
Updates to OSCAL Metaschema documentation and constraints (usnistgov#…
ffd5032 
…1263)

* completed partial update of the Metadata object documentation.
* adjustments to roles
* adjusted the cardinality of location/address to make address optional.
* Improved documentation and constraints related to location and parties
* addressed the remainder of metadata and control feedback from @Rene2mt.
* Improved the introductory remarks for a profile to better describe what a profile is and what it does.
* Fixed a broken constraint that was not targeting the right node.
* started refining descriptions and adding properties to describe identifier attributes.
* Addressed feedback from AJ during 20220718-20220722. (#48)
* Week 30 feedback on SSP model. (#49)
* Proposed metaschema docs updates (#50)
* Addressed feedback based on usnistgov#1392
* Adjustments based on model review feedback on 8/12.
* Removed outdated merge phase remarks. Created issue #53 to address this.
* Addressed A.J. Stein's Week 32 Feedback for Model Review (#52)
* Addressed AJ Stein's week 32 feedback for usnistgov#1331.
* Addressed DRAFT: Update catalog & profile metaschema documentation (#51)
* Update catalog & profile metaschema documentation
* Add props to control identifier
* Fixed broken syntax and addressed consistency in wording within the Profile 'merge' construct.
* Adjustments to alter, moving to to an inline definition
* cleaned up empty remark.
* Removed redundant constraints
* removed some redundant constraints
* Preliminary work on URI documentation to address usnistgov#1249.
* More work on document URI use in OSCAL
* Updating data types related to usnistgov/metaschema#224.
* Improved consistency of how URI concepts are discussed.
* Added note about party locations
* Updated Metaschema instances of `uri` and `uri-reference` data types to indicate their URI semantics. Resolves usnistgov#1249.
* Added identifier props to control layer metaschemas (#55)
* Responding to usnistgov#1066: metaschema edits; CSS enhancement (#56)
* Whitespace cleanup in metadata metaschema
* Apply suggestions from code review

Co-authored-by: Alexander Stein <alexander.stein@nist.gov>
Co-authored-by: Wendell Piez <wapiez@wendellpiez.com>
Co-authored-by: Rene Tshiteya <rene-claude.tshiteya@gsa.gov>
aj-stein-nist added a commit to aj-stein-nist/OSCAL-forked that referenced this issue Jul 10, 2023
@david-waltermire @aj-stein-nist
@wendellpiez @Rene2mt
Updates to OSCAL Metaschema documentation and constraints (usnistgov#…
988817c 
…1263)

* completed partial update of the Metadata object documentation.
* adjustments to roles
* adjusted the cardinality of location/address to make address optional.
* Improved documentation and constraints related to location and parties
* addressed the remainder of metadata and control feedback from @Rene2mt.
* Improved the introductory remarks for a profile to better describe what a profile is and what it does.
* Fixed a broken constraint that was not targeting the right node.
* started refining descriptions and adding properties to describe identifier attributes.
* Addressed feedback from AJ during 20220718-20220722. (#48)
* Week 30 feedback on SSP model. (#49)
* Proposed metaschema docs updates (#50)
* Addressed feedback based on usnistgov#1392
* Adjustments based on model review feedback on 8/12.
* Removed outdated merge phase remarks. Created issue #53 to address this.
* Addressed A.J. Stein's Week 32 Feedback for Model Review (#52)
* Addressed AJ Stein's week 32 feedback for usnistgov#1331.
* Addressed DRAFT: Update catalog & profile metaschema documentation (#51)
* Update catalog & profile metaschema documentation
* Add props to control identifier
* Fixed broken syntax and addressed consistency in wording within the Profile 'merge' construct.
* Adjustments to alter, moving to to an inline definition
* cleaned up empty remark.
* Removed redundant constraints
* removed some redundant constraints
* Preliminary work on URI documentation to address usnistgov#1249.
* More work on document URI use in OSCAL
* Updating data types related to usnistgov/metaschema#224.
* Improved consistency of how URI concepts are discussed.
* Added note about party locations
* Updated Metaschema instances of `uri` and `uri-reference` data types to indicate their URI semantics. Resolves usnistgov#1249.
* Added identifier props to control layer metaschemas (#55)
* Responding to usnistgov#1066: metaschema edits; CSS enhancement (#56)
* Whitespace cleanup in metadata metaschema
* Apply suggestions from code review

Co-authored-by: Alexander Stein <alexander.stein@nist.gov>
Co-authored-by: Wendell Piez <wapiez@wendellpiez.com>
Co-authored-by: Rene Tshiteya <rene-claude.tshiteya@gsa.gov>
aj-stein-nist added a commit to galtm/OSCAL that referenced this issue Sep 28, 2023
@david-waltermire @aj-stein-nist
@wendellpiez @Rene2mt
Updates to OSCAL Metaschema documentation and constraints (usnistgov#…
947048d 
…1263)

* completed partial update of the Metadata object documentation.
* adjustments to roles
* adjusted the cardinality of location/address to make address optional.
* Improved documentation and constraints related to location and parties
* addressed the remainder of metadata and control feedback from @Rene2mt.
* Improved the introductory remarks for a profile to better describe what a profile is and what it does.
* Fixed a broken constraint that was not targeting the right node.
* started refining descriptions and adding properties to describe identifier attributes.
* Addressed feedback from AJ during 20220718-20220722. (#48)
* Week 30 feedback on SSP model. (#49)
* Proposed metaschema docs updates (#50)
* Addressed feedback based on usnistgov#1392
* Adjustments based on model review feedback on 8/12.
* Removed outdated merge phase remarks. Created issue #53 to address this.
* Addressed A.J. Stein's Week 32 Feedback for Model Review (#52)
* Addressed AJ Stein's week 32 feedback for usnistgov#1331.
* Addressed DRAFT: Update catalog & profile metaschema documentation (#51)
* Update catalog & profile metaschema documentation
* Add props to control identifier
* Fixed broken syntax and addressed consistency in wording within the Profile 'merge' construct.
* Adjustments to alter, moving to to an inline definition
* cleaned up empty remark.
* Removed redundant constraints
* removed some redundant constraints
* Preliminary work on URI documentation to address usnistgov#1249.
* More work on document URI use in OSCAL
* Updating data types related to usnistgov/metaschema#224.
* Improved consistency of how URI concepts are discussed.
* Added note about party locations
* Updated Metaschema instances of `uri` and `uri-reference` data types to indicate their URI semantics. Resolves usnistgov#1249.
* Added identifier props to control layer metaschemas (#55)
* Responding to usnistgov#1066: metaschema edits; CSS enhancement (#56)
* Whitespace cleanup in metadata metaschema
* Apply suggestions from code review

Co-authored-by: Alexander Stein <alexander.stein@nist.gov>
Co-authored-by: Wendell Piez <wapiez@wendellpiez.com>
Co-authored-by: Rene Tshiteya <rene-claude.tshiteya@gsa.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wendellpiez wendellpiez

Labels
enhancement User Story
Projects
NIST OSCAL Work Board
Status: Done
Milestone
v1.1.0
Development

No branches or pull requests
2 participants
@wendellpiez @david-waltermire