Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds external interface testing for PQC algos #1551

Merged
merged 3 commits into from
Jan 13, 2025

Conversation

celic
Copy link
Collaborator

@celic celic commented Jan 9, 2025

No description provided.

@celic celic requested a review from livebe01 January 9, 2025 00:22
@smuellerDD
Copy link
Contributor

The list of hashes looks overly permissive (more than the lambda * 2). Is the server restricting the hashes for pre-hashed variants?

Also, why are there 2 interface type definitions? IMHO there should only be one, no? Internal, external and externallmu.

Also, would it make sense to drop the prehash keyword and the presence of hash algos indicates prehash, no?

@celic
Copy link
Collaborator Author

celic commented Jan 9, 2025 via email

@livebe01 livebe01 merged commit 866a90f into master Jan 13, 2025
2 checks passed
@livebe01 livebe01 deleted the FEATURE/PqcExternalInterfaces branch January 13, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants