2.6 post launch fixes #910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix the way keepOnTop event listener was added so that eventListeners is always defined
Skip any reports without locations and avoid undefined errors
$this-> was being used in a static function. Changed to self::
ghost
assigned Costs us 2kb in download size, worth it.
|
These have been pushed up to Crowdmap but this needs to remain open until someone can pull it into Ushahidi core. |
Same issue as with the clusters code.
|
@brianherbert added 1 more fix you probably want |
|
@kamaulynder any progress on merging this for release? .. we're getting these bugs resubmitted now.. |
Closed
Fixes security issue discovered by Timothy D. Morgan <tim.morgan@owasp.org> Forgotten password challenges were guessable based on users last login and email address. Tokens are now generated based on a HMAC of login time and email address using a salt and secret key specifically for these tokens.
|
Yes. On Mon, Nov 12, 2012 at 1:24 AM, Robbie MacKay notifications@github.comwrote:
Too brief? Here's why! http://emailcharter.org |
|
Consider this for inclusion: 14f424e |
Conflicts: application/i18n
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kamaulynder heres the fixes for 2.6 .. merge them when your ready to do the retagging etc. Maybe its worth waiting another couple of days for fixes to accumulate and pushing a 2.6.1 all the fixes at once?
I've skipped the CDN fix since its only really relevant for Crowdmap
@brianherbert This includes a couple of fixes not on crowdmap yet
e951d34 fix for mobile alerts is a little more minor
f8a167d is major, and fixes the issue Heather has emailed about (missing map on reports pages)
cc/ @evansims