Default report time for web submissions is almost always wrong #1130
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
$incident_hour
array used by the web report submission forms looks like this:However, in application/controllers/reports.php, the default value for
$form['incident_hour']
is:$form['incident_hour'] = date('g');
(12-hour format of an hour without leading zeros)So the resulting value will not have a leading zero, and the form helper never finds a match when hour is less than 10, and always defaults to "01". Probably just a typo ;-).
This needs to be
date('h')
instead, like what is used inapplication/controllers/admin/reports.php
andapplication/controllers/members/reports.php
.