Make nav helper more friendly and filterable for plugins and themes. #1125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| $menu_items[] = array( | ||
| 'page' => 'home', | ||
| 'url' => $site.'main', |
There was a problem hiding this comment.
I'd rather see url::site() used properly like
'url' => url::site('main'),
Same for other links
|
Looks good. Definitely a sensible change. |
|
@rjmackay done. |
|
Great - merging it in |
rjmackay
added a commit
that referenced
this pull request
May 27, 2013
Make nav helper more friendly and filterable for plugins and themes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Currently, the navigation menu generated by the
navhelper cannot be filtered - meaning that it's not possible to modify the default menu items or change their ordering without generating the whole thing yourself.It would be helpful if all the menu items could be filtered. The attached code also cleans up how the HTML is generated to remove redundancy.