Unable to create new users - database error - no default value for riverid

[solarissmoke]

On a clean install of Ushahidi, I tried to create an account from /ushahidi/login. The following error is thrown:

Database error: Field 'riverid' doesn't have a default value - 
INSERT INTO `users` (`email`, `username`, `password`, `name`) VALUES ('test@example.com', '281921918', 'a05534c598a1c092fb9ac86d2f0c8261b7d49fcc3d15c06f14', 'test')

Same thing happens when I try to create a user through the admin interface (/ushahidi/admin/users/edit/).

When riverid is disabled, the controller does not supply a value for $user->riverid, and the database does not have a default value, hence the fatal error.

Also note that the username value above is a large integer - I'm not sure why that is, but it also looks like a bug?

[solarissmoke]

The attached patch fixes the issue for me. Another alternative would be to change the database schema so that riverid has an empty string as the default value.

[aoduor]

Hey @solarissmoke, what version of Ushahidi are you using? Just tested this with 2.7 and was unable to reproduce.

[solarissmoke]

@aoduor, I can reproduce it in 2.7 as well as the HEAD of the develop branch. I did a completely clean install and it still happens for me. Note that riverid has to be disabled in the config (riverid.enabled should be false).

Also, if you just look at the logic, there is a problem. riverid does not have a default value in the database, but the constructor only gives it a value inside the if block (when riverid is enabled). It should be setting a value all the time given that there is no default.

[rjmackay]

@solarissmoke What version of mysql are you running?
I doubt it makes any difference, but I'd like to figure out why this is break for you but not others before merging it in.
However the change itself looks good.

[solarissmoke]

@rjmackay I can reproduce it on two systems, one running version 5.1.46 and the other version 5.5.31.

[rjmackay]

OK going to merge this since it seems sane anyway. But can't figure out why you're getting errors while I'm not.
Version of php maybe..